* Re: [PATCH/RFC 06/10] arm64: dts: r8a7795: add EthernetAVB device node
2015-08-27 9:24 [PATCH/RFC 06/10] arm64: dts: r8a7795: add EthernetAVB device node Simon Horman
@ 2015-08-27 10:41 ` Sergei Shtylyov
2015-08-27 11:00 ` Geert Uytterhoeven
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Sergei Shtylyov @ 2015-08-27 10:41 UTC (permalink / raw)
To: linux-sh
On 8/27/2015 12:24 PM, Simon Horman wrote:
> From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
>
> Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
> [horms: moved to soc node; updated changelog]
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
> arch/arm64/boot/dts/renesas/r8a7795.dtsi | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> index 0b435d8274e4..01502f4d2f5f 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> @@ -263,6 +263,16 @@
> reg = <0 0xe6060000 0 0x50c>;
> };
>
> + avb: ethernet@e6800000 {
> + compatible = "renesas,etheravb-r8a7795";
> + reg = <0 0xe6800000 0 0x800>, <0 0xe6a00000 0 0x10000>;
> + interrupts = <GIC_SPI 61 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 63 IRQ_TYPE_LEVEL_HIGH>;
Two interrupts?
> + clocks = <&mstp8_clks R8A7795_CLK_AVB>;
> + phy-mode = "rgmii-id";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + };
> +
> scif2: serial@e6e88000 {
> compatible = "renesas,scif-r8a7795", "renesas,scif";
> reg = <0 0xe6e88000 0 64>;
> @@ -362,5 +372,4 @@
> status = "disabled";
> };
> };
> -
> };
Hm?
MBR, Sergei
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH/RFC 06/10] arm64: dts: r8a7795: add EthernetAVB device node
2015-08-27 9:24 [PATCH/RFC 06/10] arm64: dts: r8a7795: add EthernetAVB device node Simon Horman
2015-08-27 10:41 ` Sergei Shtylyov
@ 2015-08-27 11:00 ` Geert Uytterhoeven
2015-08-27 11:38 ` Sergei Shtylyov
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Geert Uytterhoeven @ 2015-08-27 11:00 UTC (permalink / raw)
To: linux-sh
On Thu, Aug 27, 2015 at 12:41 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
>> diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>> b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>> index 0b435d8274e4..01502f4d2f5f 100644
>> --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>> +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>> @@ -263,6 +263,16 @@
>> reg = <0 0xe6060000 0 0x50c>;
>> };
>>
>> + avb: ethernet@e6800000 {
>> + compatible = "renesas,etheravb-r8a7795";
>> + reg = <0 0xe6800000 0 0x800>, <0 0xe6a00000 0
>> 0x10000>;
>> + interrupts = <GIC_SPI 61 IRQ_TYPE_LEVEL_HIGH>,
>> <GIC_SPI 63 IRQ_TYPE_LEVEL_HIGH>;
>
> Two interrupts?
There are actually 25, for ch0-ch24.
Why does this list the interrupts for ch22 and ch24 only?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH/RFC 06/10] arm64: dts: r8a7795: add EthernetAVB device node
2015-08-27 9:24 [PATCH/RFC 06/10] arm64: dts: r8a7795: add EthernetAVB device node Simon Horman
2015-08-27 10:41 ` Sergei Shtylyov
2015-08-27 11:00 ` Geert Uytterhoeven
@ 2015-08-27 11:38 ` Sergei Shtylyov
2015-08-27 11:44 ` Geert Uytterhoeven
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Sergei Shtylyov @ 2015-08-27 11:38 UTC (permalink / raw)
To: linux-sh
Hello.
On 8/27/2015 2:00 PM, Geert Uytterhoeven wrote:
>>> diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>> b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>> index 0b435d8274e4..01502f4d2f5f 100644
>>> --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>> +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>> @@ -263,6 +263,16 @@
>>> reg = <0 0xe6060000 0 0x50c>;
>>> };
>>>
>>> + avb: ethernet@e6800000 {
>>> + compatible = "renesas,etheravb-r8a7795";
>>> + reg = <0 0xe6800000 0 0x800>, <0 0xe6a00000 0
>>> 0x10000>;
>>> + interrupts = <GIC_SPI 61 IRQ_TYPE_LEVEL_HIGH>,
>>> <GIC_SPI 63 IRQ_TYPE_LEVEL_HIGH>;
>>
>> Two interrupts?
>
> There are actually 25, for ch0-ch24.
> Why does this list the interrupts for ch22 and ch24 only?
So all these are AVB-DMAC interrupts, not EMAC? I don't have the manual...
> Gr{oetje,eeting}s,
> Geert
MBR, Sergei
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH/RFC 06/10] arm64: dts: r8a7795: add EthernetAVB device node
2015-08-27 9:24 [PATCH/RFC 06/10] arm64: dts: r8a7795: add EthernetAVB device node Simon Horman
` (2 preceding siblings ...)
2015-08-27 11:38 ` Sergei Shtylyov
@ 2015-08-27 11:44 ` Geert Uytterhoeven
2015-08-27 12:32 ` Sergei Shtylyov
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Geert Uytterhoeven @ 2015-08-27 11:44 UTC (permalink / raw)
To: linux-sh
Hi Sergei,
On Thu, Aug 27, 2015 at 1:38 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> On 8/27/2015 2:00 PM, Geert Uytterhoeven wrote:
>>>> diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>>> b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>>> index 0b435d8274e4..01502f4d2f5f 100644
>>>> --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>>> +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>>> @@ -263,6 +263,16 @@
>>>> reg = <0 0xe6060000 0 0x50c>;
>>>> };
>>>>
>>>> + avb: ethernet@e6800000 {
>>>> + compatible = "renesas,etheravb-r8a7795";
>>>> + reg = <0 0xe6800000 0 0x800>, <0 0xe6a00000 0
>>>> 0x10000>;
>>>> + interrupts = <GIC_SPI 61 IRQ_TYPE_LEVEL_HIGH>,
>>>> <GIC_SPI 63 IRQ_TYPE_LEVEL_HIGH>;
>>>
>>> Two interrupts?
>>
>> There are actually 25, for ch0-ch24.
>> Why does this list the interrupts for ch22 and ch24 only?
>
> So all these are AVB-DMAC interrupts, not EMAC? I don't have the
> manual...
The block diagram just shows a line "intreq_avb_p[24:0] (to INTC)", coming
from both AVB-DMAC and E-MAC.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH/RFC 06/10] arm64: dts: r8a7795: add EthernetAVB device node
2015-08-27 9:24 [PATCH/RFC 06/10] arm64: dts: r8a7795: add EthernetAVB device node Simon Horman
` (3 preceding siblings ...)
2015-08-27 11:44 ` Geert Uytterhoeven
@ 2015-08-27 12:32 ` Sergei Shtylyov
2015-08-27 12:52 ` Sergei Shtylyov
2015-08-27 19:43 ` Sergei Shtylyov
6 siblings, 0 replies; 8+ messages in thread
From: Sergei Shtylyov @ 2015-08-27 12:32 UTC (permalink / raw)
To: linux-sh
On 8/27/2015 2:44 PM, Geert Uytterhoeven wrote:
>>>>> diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>>>> b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>>>> index 0b435d8274e4..01502f4d2f5f 100644
>>>>> --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>>>> +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>>>> @@ -263,6 +263,16 @@
>>>>> reg = <0 0xe6060000 0 0x50c>;
>>>>> };
>>>>>
>>>>> + avb: ethernet@e6800000 {
>>>>> + compatible = "renesas,etheravb-r8a7795";
>>>>> + reg = <0 0xe6800000 0 0x800>, <0 0xe6a00000 0
>>>>> 0x10000>;
>>>>> + interrupts = <GIC_SPI 61 IRQ_TYPE_LEVEL_HIGH>,
>>>>> <GIC_SPI 63 IRQ_TYPE_LEVEL_HIGH>;
>>>>
>>>> Two interrupts?
>>>
>>> There are actually 25, for ch0-ch24.
>>> Why does this list the interrupts for ch22 and ch24 only?
>>
>> So all these are AVB-DMAC interrupts, not EMAC? I don't have the
>> manual...
>
> The block diagram just shows a line "intreq_avb_p[24:0] (to INTC)", coming
> from both AVB-DMAC and E-MAC.
Then I'll have to NACK the driver patch. It's interesting that there's 24
IRQs while I remember there were only 15 RX queues on gen2 SoCs. That's the
only interpretation of the multiple IRQs that comes to mind.
> Gr{oetje,eeting}s,
> Geert
MBR, Sergei
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH/RFC 06/10] arm64: dts: r8a7795: add EthernetAVB device node
2015-08-27 9:24 [PATCH/RFC 06/10] arm64: dts: r8a7795: add EthernetAVB device node Simon Horman
` (4 preceding siblings ...)
2015-08-27 12:32 ` Sergei Shtylyov
@ 2015-08-27 12:52 ` Sergei Shtylyov
2015-08-27 19:43 ` Sergei Shtylyov
6 siblings, 0 replies; 8+ messages in thread
From: Sergei Shtylyov @ 2015-08-27 12:52 UTC (permalink / raw)
To: linux-sh
On 8/27/2015 3:32 PM, Sergei Shtylyov wrote:
>>>>>> diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>>>>> b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>>>>> index 0b435d8274e4..01502f4d2f5f 100644
>>>>>> --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>>>>> +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>>>>> @@ -263,6 +263,16 @@
>>>>>> reg = <0 0xe6060000 0 0x50c>;
>>>>>> };
>>>>>>
>>>>>> + avb: ethernet@e6800000 {
>>>>>> + compatible = "renesas,etheravb-r8a7795";
>>>>>> + reg = <0 0xe6800000 0 0x800>, <0 0xe6a00000 0
>>>>>> 0x10000>;
>>>>>> + interrupts = <GIC_SPI 61 IRQ_TYPE_LEVEL_HIGH>,
>>>>>> <GIC_SPI 63 IRQ_TYPE_LEVEL_HIGH>;
>>>>>
>>>>> Two interrupts?
>>>>
>>>> There are actually 25, for ch0-ch24.
>>>> Why does this list the interrupts for ch22 and ch24 only?
>>>
>>> So all these are AVB-DMAC interrupts, not EMAC? I don't have the
>>> manual...
>>
>> The block diagram just shows a line "intreq_avb_p[24:0] (to INTC)", coming
>> from both AVB-DMAC and E-MAC.
> Then I'll have to NACK the driver patch. It's interesting that there's 24
> IRQs while I remember there were only 15 RX queues on gen2 SoCs. That's the
> only interpretation of the multiple IRQs that comes to mind.
Oops, I meant the descriptor interrupt #s (not used by the driver now),
not the RX queues.
>> Gr{oetje,eeting}s,
>> Geert
MBR, Sergei
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH/RFC 06/10] arm64: dts: r8a7795: add EthernetAVB device node
2015-08-27 9:24 [PATCH/RFC 06/10] arm64: dts: r8a7795: add EthernetAVB device node Simon Horman
` (5 preceding siblings ...)
2015-08-27 12:52 ` Sergei Shtylyov
@ 2015-08-27 19:43 ` Sergei Shtylyov
6 siblings, 0 replies; 8+ messages in thread
From: Sergei Shtylyov @ 2015-08-27 19:43 UTC (permalink / raw)
To: linux-sh
On 08/27/2015 03:52 PM, Sergei Shtylyov wrote:
>>>>>>> diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>>>>>> b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>>>>>> index 0b435d8274e4..01502f4d2f5f 100644
>>>>>>> --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>>>>>> +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>>>>>> @@ -263,6 +263,16 @@
>>>>>>> reg = <0 0xe6060000 0 0x50c>;
>>>>>>> };
>>>>>>>
>>>>>>> + avb: ethernet@e6800000 {
>>>>>>> + compatible = "renesas,etheravb-r8a7795";
>>>>>>> + reg = <0 0xe6800000 0 0x800>, <0 0xe6a00000 0
>>>>>>> 0x10000>;
>>>>>>> + interrupts = <GIC_SPI 61 IRQ_TYPE_LEVEL_HIGH>,
>>>>>>> <GIC_SPI 63 IRQ_TYPE_LEVEL_HIGH>;
>>>>>>
>>>>>> Two interrupts?
>>>>>
>>>>> There are actually 25, for ch0-ch24.
>>>>> Why does this list the interrupts for ch22 and ch24 only?
>>>>
>>>> So all these are AVB-DMAC interrupts, not EMAC? I don't have the
>>>> manual...
>>>
>>> The block diagram just shows a line "intreq_avb_p[24:0] (to INTC)", coming
>>> from both AVB-DMAC and E-MAC.
>
>> Then I'll have to NACK the driver patch.
Yeah, it seems to be total nonsense now... Unless there's some more recent
knowledge behind it than Geert's manual has. :-)
>> It's interesting that there's 24
25 even.
>> IRQs while I remember there were only 15 RX queues on gen2 SoCs.
Actually, 18.
>> That's the only interpretation of the multiple IRQs that comes to mind.
> Oops, I meant the descriptor interrupt #s (not used by the driver now),
> not the RX queues.
After looking thru the gen2 manual, it seems to me that these channels may
be representing 4 TX and 21 RX queues.
>>> Gr{oetje,eeting}s,
>>> Geert
MBR, Sergei
^ permalink raw reply [flat|nested] 8+ messages in thread