Re: [PATCH v6 03/05] clk: shmobile: Make MSTP clock-output-names optional

[Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>]

Hello.

On 9/2/2015 10:17 AM, Magnus Damm wrote:

> From: Magnus Damm <damm+renesas@opensource.se>
>
> This patch updates the MSTP driver to make the "clock-output-names"
> DT property optional instead of mandatory. In case the DT property
> is omitted then the function clk_register_clkdev() is skipped.
>
> The default for new SoCs is to not use "clock-output-names".
>
> Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
> ---
>
>   Changes since V5:
>   - Simplified code using const char *allocated_name - thanks Geert!
>
>   Changes since V4:
>   - None
>
>   Changes since V3:
>   - Added support for multiple MSTP bits. =)
>
>   drivers/clk/shmobile/clk-mstp.c |   24 +++++++++++++++---------
>   1 file changed, 15 insertions(+), 9 deletions(-)
>
> --- 0001/drivers/clk/shmobile/clk-mstp.c
> +++ work/drivers/clk/shmobile/clk-mstp.c	2015-09-02 11:52:02.182366518 +0900
> @@ -193,26 +193,26 @@ static void __init cpg_mstp_clocks_init(
[...]
>   		parent_name = of_clk_get_parent_name(np, i);
>   		ret = of_property_read_u32_index(np, idxname, i, &clkidx);
>   		if (parent_name = NULL || ret < 0)
>   			break;
>
>   		if (clkidx >= MSTP_MAX_CLOCKS) {
> -			pr_err("%s: invalid clock %s %s index %u)\n",
> -			       __func__, np->name, name, clkidx);
> +			pr_err("%s: invalid clock %s index %u)\n",
> +			       __func__, np->name, clkidx);
>   			continue;
>   		}
>
> +		if (of_property_read_string_index(np, "clock-output-names",
> +						  i, &name) < 0)
> +			allocated_name = name = kasprintf(GFP_KERNEL, "%s.%u",
> +							   np->name, clkidx);

    There's too many spaces on this line, it's a bit over-indented.

[...]

MBR, Sergei