From: Hans Verkuil <hverkuil@xs4all.nl>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
g.liakhovetski@gmx.de, mchehab@osg.samsung.com,
linux-media@vger.kernel.org
Cc: linux-sh@vger.kernel.org
Subject: Re: [PATCH 3/3] rcar_vin: call g_std() instead of querystd()
Date: Fri, 04 Sep 2015 11:36:00 +0000 [thread overview]
Message-ID: <55E98220.1080801@xs4all.nl> (raw)
In-Reply-To: <2719391.j5OZOaG8ai@wasted.cogentembedded.com>
On 09/04/2015 01:18 AM, Sergei Shtylyov wrote:
> Hans Verkuil says: "The only place querystd can be called is in the QUERYSTD
> ioctl, all other ioctls should use the last set standard." So call the g_std()
> subdevice method instead of querystd() in the driver's set_fmt() method.
>
> Reported-by: Hans Verkuil <hverkuil@xs4all.nl>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
>
> ---
> drivers/media/platform/soc_camera/rcar_vin.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: media_tree/drivers/media/platform/soc_camera/rcar_vin.c
> =================================> --- media_tree.orig/drivers/media/platform/soc_camera/rcar_vin.c
> +++ media_tree/drivers/media/platform/soc_camera/rcar_vin.c
> @@ -1589,8 +1589,8 @@ static int rcar_vin_set_fmt(struct soc_c
> field = pix->field;
> break;
> case V4L2_FIELD_INTERLACED:
> - /* Query for standard if not explicitly mentioned _TB/_BT */
> - ret = v4l2_subdev_call(sd, video, querystd, &std);
> + /* Get the last standard if not explicitly mentioned _TB/_BT */
> + ret = v4l2_subdev_call(sd, video, g_std, &std);
> if (ret = -ENOIOCTLCMD) {
> field = V4L2_FIELD_NONE;
> } else if (ret < 0) {
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2015-09-04 11:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-03 23:12 [PATCH 0/3] VIN: call g std() method as requested by Hans Sergei Shtylyov
2015-09-03 23:14 ` [PATCH 1/3] adv7180: implement g_std() method Sergei Shtylyov
2015-09-04 12:08 ` Hans Verkuil
2015-09-04 12:32 ` Hans Verkuil
2015-09-03 23:16 ` [PATCH 2/3] ml86v7667: " Sergei Shtylyov
2015-09-04 11:35 ` Hans Verkuil
2015-09-03 23:18 ` [PATCH 3/3] rcar_vin: call g_std() instead of querystd() Sergei Shtylyov
2015-09-04 11:36 ` Hans Verkuil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E98220.1080801@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=g.liakhovetski@gmx.de \
--cc=linux-media@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox