linux-sh.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>,
	Wolfram Sang <wsa@the-dreams.de>
Cc: linux-i2c@vger.kernel.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH] i2c: rcar: Remove obsolete platform data support
Date: Wed, 07 Oct 2015 12:12:34 +0000	[thread overview]
Message-ID: <56150C32.5040700@cogentembedded.com> (raw)
In-Reply-To: <1444205791-25480-1-git-send-email-geert+renesas@glider.be>

Hello.

On 10/7/2015 11:16 AM, Geert Uytterhoeven wrote:

> Since commit 4baadb9e05c68962 ("ARM: shmobile: r8a7778: remove obsolete
> setup code"), Renesas R-Car SoCs are only supported in generic DT-only
> ARM multi-platform builds.  The driver doesn't need to use platform data
> anymore, hence remove platform data configuration.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Commit 4baadb9e05c68962 is now in arm-soc/for-next.
> ---
>   drivers/i2c/busses/i2c-rcar.c | 19 +------------------
>   include/linux/i2c/i2c-rcar.h  | 10 ----------
>   2 files changed, 1 insertion(+), 28 deletions(-)
>   delete mode 100644 include/linux/i2c/i2c-rcar.h
>
> diff --git a/drivers/i2c/busses/i2c-rcar.c b/drivers/i2c/busses/i2c-rcar.c
> index 3e125654bb28..cd38406db074 100644
> --- a/drivers/i2c/busses/i2c-rcar.c
> +++ b/drivers/i2c/busses/i2c-rcar.c
[...]
> @@ -654,14 +652,8 @@ static int rcar_i2c_probe(struct platform_device *pdev)
>
>   	bus_speed = 100000; /* default 100 kHz */
>   	ret = of_property_read_u32(dev->of_node, "clock-frequency", &bus_speed);

    The result can be ignored now.

> -	if (ret < 0 && pdata && pdata->bus_speed)
> -		bus_speed = pdata->bus_speed;
>
> -	if (pdev->dev.of_node)
> -		priv->devtype = (long)of_match_device(rcar_i2c_dt_ids,
> -						      dev)->data;
> -	else
> -		priv->devtype = platform_get_device_id(pdev)->driver_data;
> +	priv->devtype = (long)of_match_device(rcar_i2c_dt_ids, dev)->data;
>
>   	ret = rcar_i2c_clock_calculate(priv, bus_speed, dev);
>   	if (ret < 0)
[...]

MBR, Sergei


  reply	other threads:[~2015-10-07 12:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-07  8:16 [PATCH] i2c: rcar: Remove obsolete platform data support Geert Uytterhoeven
2015-10-07 12:12 ` Sergei Shtylyov [this message]
2015-10-20 16:11   ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56150C32.5040700@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=geert+renesas@glider.be \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).