* [PATCH 01/02] ARM: shmobile: r8a7794: Add DU device and MSTP clocks
@ 2015-10-18 5:13 Magnus Damm
2015-10-18 11:31 ` Sergei Shtylyov
2015-10-20 9:00 ` Magnus Damm
0 siblings, 2 replies; 3+ messages in thread
From: Magnus Damm @ 2015-10-18 5:13 UTC (permalink / raw)
To: linux-sh
From: Magnus Damm <damm+renesas@opensource.se>
Add a DU device tree node for the r8a7794 SoC and hook it up
to the required MSTP clocks. As usual the device is disabled
by default and we rely on the board specific code to provide
more board specific details and enable the device.
Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
---
Written against renesas-devel-20151015-v4.3-rc5
No special compile time dependencies.
Run time dependency on "drm: rcar-du: Add support for the R8A7794 DU"
arch/arm/boot/dts/r8a7794.dtsi | 36 ++++++++++++++++++++++++++---
include/dt-bindings/clock/r8a7794-clock.h | 2 +
2 files changed, 35 insertions(+), 3 deletions(-)
--- 0001/arch/arm/boot/dts/r8a7794.dtsi
+++ work/arch/arm/boot/dts/r8a7794.dtsi 2015-10-18 13:44:22.130513000 +0900
@@ -750,6 +750,34 @@
};
};
+ du: display@feb00000 {
+ compatible = "renesas,du-r8a7794";
+ reg = <0 0xfeb00000 0 0x40000>;
+ reg-names = "du";
+ interrupts = <0 256 IRQ_TYPE_LEVEL_HIGH>,
+ <0 268 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&mstp7_clks R8A7794_CLK_DU0>,
+ <&mstp7_clks R8A7794_CLK_DU1>;
+ clock-names = "du.0", "du.1";
+ status = "disabled";
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+ du_out_rgb0: endpoint {
+ };
+ };
+ port@1 {
+ reg = <1>;
+ du_out_rgb1: endpoint {
+ };
+ };
+ };
+ };
+
clocks {
#address-cells = <2>;
#size-cells = <2>;
@@ -1025,19 +1053,21 @@
reg = <0 0xe615014c 0 4>, <0 0xe61501c4 0 4>;
clocks = <&mp_clk>, <&mp_clk>,
<&zs_clk>, <&p_clk>, <&p_clk>, <&zs_clk>,
- <&zs_clk>, <&p_clk>, <&p_clk>, <&p_clk>, <&p_clk>;
+ <&zs_clk>, <&p_clk>, <&p_clk>, <&p_clk>,
+ <&p_clk>, <&zx_clk>, <&zx_clk>;
#clock-cells = <1>;
clock-indices = <
R8A7794_CLK_EHCI R8A7794_CLK_HSUSB
R8A7794_CLK_HSCIF2 R8A7794_CLK_SCIF5
R8A7794_CLK_SCIF4 R8A7794_CLK_HSCIF1 R8A7794_CLK_HSCIF0
R8A7794_CLK_SCIF3 R8A7794_CLK_SCIF2 R8A7794_CLK_SCIF1
- R8A7794_CLK_SCIF0
+ R8A7794_CLK_SCIF0 R8A7794_CLK_DU1 R8A7794_CLK_DU0
>;
clock-output-names "ehci", "hsusb",
"hscif2", "scif5", "scif4", "hscif1", "hscif0",
- "scif3", "scif2", "scif1", "scif0";
+ "scif3", "scif2", "scif1", "scif0",
+ "du2", "du1";
};
mstp8_clks: mstp8_clks@e6150990 {
compatible = "renesas,r8a7794-mstp-clocks", "renesas,cpg-mstp-clocks";
--- 0001/include/dt-bindings/clock/r8a7794-clock.h
+++ work/include/dt-bindings/clock/r8a7794-clock.h 2015-10-18 13:44:22.130513000 +0900
@@ -79,6 +79,8 @@
#define R8A7794_CLK_SCIF2 19
#define R8A7794_CLK_SCIF1 20
#define R8A7794_CLK_SCIF0 21
+#define R8A7794_CLK_DU1 23
+#define R8A7794_CLK_DU0 24
/* MSTP8 */
#define R8A7794_CLK_VIN1 10
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 01/02] ARM: shmobile: r8a7794: Add DU device and MSTP clocks
2015-10-18 5:13 [PATCH 01/02] ARM: shmobile: r8a7794: Add DU device and MSTP clocks Magnus Damm
@ 2015-10-18 11:31 ` Sergei Shtylyov
2015-10-20 9:00 ` Magnus Damm
1 sibling, 0 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2015-10-18 11:31 UTC (permalink / raw)
To: linux-sh
Hello.
On 10/18/2015 8:13 AM, Magnus Damm wrote:
> From: Magnus Damm <damm+renesas@opensource.se>
>
> Add a DU device tree node for the r8a7794 SoC and hook it up
> to the required MSTP clocks. As usual the device is disabled
> by default and we rely on the board specific code to provide
> more board specific details and enable the device.
>
> Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
> ---
>
> Written against renesas-devel-20151015-v4.3-rc5
> No special compile time dependencies.
> Run time dependency on "drm: rcar-du: Add support for the R8A7794 DU"
>
> arch/arm/boot/dts/r8a7794.dtsi | 36 ++++++++++++++++++++++++++---
> include/dt-bindings/clock/r8a7794-clock.h | 2 +
> 2 files changed, 35 insertions(+), 3 deletions(-)
>
> --- 0001/arch/arm/boot/dts/r8a7794.dtsi
> +++ work/arch/arm/boot/dts/r8a7794.dtsi 2015-10-18 13:44:22.130513000 +0900
[...]
> @@ -1025,19 +1053,21 @@
> reg = <0 0xe615014c 0 4>, <0 0xe61501c4 0 4>;
> clocks = <&mp_clk>, <&mp_clk>,
> <&zs_clk>, <&p_clk>, <&p_clk>, <&zs_clk>,
> - <&zs_clk>, <&p_clk>, <&p_clk>, <&p_clk>, <&p_clk>;
> + <&zs_clk>, <&p_clk>, <&p_clk>, <&p_clk>,
> + <&p_clk>, <&zx_clk>, <&zx_clk>;
> #clock-cells = <1>;
> clock-indices = <
> R8A7794_CLK_EHCI R8A7794_CLK_HSUSB
> R8A7794_CLK_HSCIF2 R8A7794_CLK_SCIF5
> R8A7794_CLK_SCIF4 R8A7794_CLK_HSCIF1 R8A7794_CLK_HSCIF0
> R8A7794_CLK_SCIF3 R8A7794_CLK_SCIF2 R8A7794_CLK_SCIF1
> - R8A7794_CLK_SCIF0
> + R8A7794_CLK_SCIF0 R8A7794_CLK_DU1 R8A7794_CLK_DU0
> >;
> clock-output-names > "ehci", "hsusb",
> "hscif2", "scif5", "scif4", "hscif1", "hscif0",
> - "scif3", "scif2", "scif1", "scif0";
> + "scif3", "scif2", "scif1", "scif0",
> + "du2", "du1";
Why not "du1", "du0"?
> };
> mstp8_clks: mstp8_clks@e6150990 {
> compatible = "renesas,r8a7794-mstp-clocks", "renesas,cpg-mstp-clocks";
> --- 0001/include/dt-bindings/clock/r8a7794-clock.h
> +++ work/include/dt-bindings/clock/r8a7794-clock.h 2015-10-18 13:44:22.130513000 +0900
> @@ -79,6 +79,8 @@
> #define R8A7794_CLK_SCIF2 19
> #define R8A7794_CLK_SCIF1 20
> #define R8A7794_CLK_SCIF0 21
> +#define R8A7794_CLK_DU1 23
> +#define R8A7794_CLK_DU0 24
>
> /* MSTP8 */
> #define R8A7794_CLK_VIN1 10
MBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 01/02] ARM: shmobile: r8a7794: Add DU device and MSTP clocks
2015-10-18 5:13 [PATCH 01/02] ARM: shmobile: r8a7794: Add DU device and MSTP clocks Magnus Damm
2015-10-18 11:31 ` Sergei Shtylyov
@ 2015-10-20 9:00 ` Magnus Damm
1 sibling, 0 replies; 3+ messages in thread
From: Magnus Damm @ 2015-10-20 9:00 UTC (permalink / raw)
To: linux-sh
Hi Sergei,
On Sun, Oct 18, 2015 at 8:31 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> Hello.
>
> On 10/18/2015 8:13 AM, Magnus Damm wrote:
>
>> From: Magnus Damm <damm+renesas@opensource.se>
>>
>> Add a DU device tree node for the r8a7794 SoC and hook it up
>> to the required MSTP clocks. As usual the device is disabled
>> by default and we rely on the board specific code to provide
>> more board specific details and enable the device.
>>
>> Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
>> ---
>>
>> Written against renesas-devel-20151015-v4.3-rc5
>> No special compile time dependencies.
>> Run time dependency on "drm: rcar-du: Add support for the R8A7794 DU"
>>
>> arch/arm/boot/dts/r8a7794.dtsi | 36
>> ++++++++++++++++++++++++++---
>> include/dt-bindings/clock/r8a7794-clock.h | 2 +
>> 2 files changed, 35 insertions(+), 3 deletions(-)
>>
>> --- 0001/arch/arm/boot/dts/r8a7794.dtsi
>> +++ work/arch/arm/boot/dts/r8a7794.dtsi 2015-10-18 13:44:22.130513000
>> +0900
>
> [...]
>>
>> @@ -1025,19 +1053,21 @@
>> reg = <0 0xe615014c 0 4>, <0 0xe61501c4 0 4>;
>> clocks = <&mp_clk>, <&mp_clk>,
>> <&zs_clk>, <&p_clk>, <&p_clk>, <&zs_clk>,
>> - <&zs_clk>, <&p_clk>, <&p_clk>, <&p_clk>,
>> <&p_clk>;
>> + <&zs_clk>, <&p_clk>, <&p_clk>, <&p_clk>,
>> + <&p_clk>, <&zx_clk>, <&zx_clk>;
>> #clock-cells = <1>;
>> clock-indices = <
>> R8A7794_CLK_EHCI R8A7794_CLK_HSUSB
>> R8A7794_CLK_HSCIF2 R8A7794_CLK_SCIF5
>> R8A7794_CLK_SCIF4 R8A7794_CLK_HSCIF1
>> R8A7794_CLK_HSCIF0
>> R8A7794_CLK_SCIF3 R8A7794_CLK_SCIF2
>> R8A7794_CLK_SCIF1
>> - R8A7794_CLK_SCIF0
>> + R8A7794_CLK_SCIF0 R8A7794_CLK_DU1
>> R8A7794_CLK_DU0
>> >;
>> clock-output-names >> "ehci", "hsusb",
>> "hscif2", "scif5", "scif4", "hscif1",
>> "hscif0",
>> - "scif3", "scif2", "scif1", "scif0";
>> + "scif3", "scif2", "scif1", "scif0",
>> + "du2", "du1";
>
>
> Why not "du1", "du0"?
Thanks for checking and providing feedback, you are correct! I will
update this and resend.
Cheers,
/ magnus
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-10-20 9:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-18 5:13 [PATCH 01/02] ARM: shmobile: r8a7794: Add DU device and MSTP clocks Magnus Damm
2015-10-18 11:31 ` Sergei Shtylyov
2015-10-20 9:00 ` Magnus Damm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).