From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Mon, 07 Dec 2015 17:44:32 +0000 Subject: Re: [PATCH net] ravb: Remove clear unhandled interrupt Message-Id: <5665C580.2090202@cogentembedded.com> List-Id: References: <1449402140-24272-1-git-send-email-ykaneko0929@gmail.com> <566489E8.8040605@cogentembedded.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Yoshihiro Kaneko Cc: netdev@vger.kernel.org, "David S. Miller" , Simon Horman , Magnus Damm , Linux-sh list Hello. On 12/07/2015 07:59 PM, Yoshihiro Kaneko wrote: >>> From: Kazuya Mizuguchi >>> >>> AVB-DMAC Reception Warning interrupt is not enabled, so it is not >>> necessary to clear the interrupt. >>> >>> Signed-off-by: Kazuya Mizuguchi >>> Signed-off-by: Yoshihiro Kaneko >> >> >> In principle I agree but perhaps we should clear RIC1 in probe() to not >> depend on a state left from a bootloader? > > I think that it is a good idea. > I'll add it to v2. Perhaps the ndo_open() method would be a better place... >> MBR, Sergei > Thanks, > Kaneko MBR, Sergei