From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH] sh_eth: move inline functions to the header file
Date: Sat, 12 Dec 2015 22:24:13 +0000 [thread overview]
Message-ID: <566C9E8D.7060704@cogentembedded.com> (raw)
In-Reply-To: <20150407.153337.1789757717574323514.davem@davemloft.net>
Hello.
On 04/07/2015 10:33 PM, David Miller wrote:
>>>> The explicitly inline functions belong to the header files, so move
>>>> cpu_to_edmac() and edmac_to_cpu() into the driver header.
>>
>>>> While at it, make these functions return 'u32' instead of '__u32'.
>>
>>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>
>>> Then... ummm... remove the inline keyword?
>>
>>> If it's not used anywhere else, that's the thing to do.
>>
>> Results in more code, as I noted in the patch posting that you skipped
>> when replying. At least with gcc 4.7.
>
> That's a compiler bug.
Just tried x86 gcc 5.1.1, same result:
$ size drivers/net/ethernet/renesas/sh_eth.o{~,}
text data bss dec hex filename
23245 1188 0 24433 5f71 drivers/net/ethernet/renesas/sh_eth.o~
23259 1188 0 24447 5f7f drivers/net/ethernet/renesas/sh_eth.o
i.e. +14 bytes of code. :-O
MBR, Sergei
prev parent reply other threads:[~2015-12-12 22:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-05 21:13 [PATCH] sh_eth: move inline functions to the header file Sergei Shtylyov
2015-04-07 13:21 ` Geert Uytterhoeven
2015-04-07 17:21 ` Sergei Shtylyov
2015-04-07 19:22 ` David Miller
2015-04-07 19:26 ` Sergei Shtylyov
2015-04-07 19:33 ` David Miller
2015-10-30 23:09 ` Sergei Shtylyov
2015-12-12 22:24 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=566C9E8D.7060704@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=linux-sh@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).