From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Yoshihiro Kaneko <ykaneko0929@gmail.com>, linux-media@vger.kernel.org
Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
Simon Horman <horms@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>,
linux-sh@vger.kernel.org
Subject: Re: [PATCH] media: soc_camera: rcar_vin: Add R-Car Gen3 support
Date: Sun, 13 Dec 2015 17:43:51 +0000 [thread overview]
Message-ID: <566DAE57.6030000@cogentembedded.com> (raw)
In-Reply-To: <1450020436-809-1-git-send-email-ykaneko0929@gmail.com>
On 12/13/2015 06:27 PM, Yoshihiro Kaneko wrote:
> From: Yoshihiko Mori <yoshihiko.mori.nx@renesas.com>
>
> Add chip identification for R-Car Gen3.
>
> Signed-off-by: Yoshihiko Mori <yoshihiko.mori.nx@renesas.com>
> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
[...]
> diff --git a/drivers/media/platform/soc_camera/rcar_vin.c b/drivers/media/platform/soc_camera/rcar_vin.c
> index 5d90f39..29e7ca4 100644
> --- a/drivers/media/platform/soc_camera/rcar_vin.c
> +++ b/drivers/media/platform/soc_camera/rcar_vin.c
> @@ -143,6 +143,7 @@
> #define RCAR_VIN_BT656 (1 << 3)
>
> enum chip_id {
> + RCAR_GEN3,
> RCAR_GEN2,
> RCAR_H1,
> RCAR_M1,
> @@ -1846,6 +1847,7 @@ static struct soc_camera_host_ops rcar_vin_host_ops = {
>
> #ifdef CONFIG_OF
> static const struct of_device_id rcar_vin_of_table[] = {
> + { .compatible = "renesas,vin-r8a7795", .data = (void *)RCAR_GEN3 },
I don't see where this is checked in the driver. Shouldn't we just use gen2?
MBR, Sergei
next prev parent reply other threads:[~2015-12-13 17:43 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-23 20:28 [PATCH] media: soc_camera: rcar_vin: Add preliminary R-Car M2 support Valentine Barshak
2013-12-26 14:18 ` Laurent Pinchart
2013-12-26 14:31 ` Valentine
2014-02-24 15:49 ` [PATCH] media: soc_camera: rcar_vin: Add support for 10-bit YUV cameras Phil Edworthy
2014-02-24 18:38 ` Laurent Pinchart
2014-02-25 9:10 ` [PATCH v2] " Phil Edworthy
2014-02-25 13:40 ` Vladimir Barinov
2014-02-25 13:40 ` [PATCH] " Valentine
2014-10-14 6:22 ` [PATCH] media: soc_camera: rcar_vin: Add BT.709 24-bit RGB888 input support Yoshihiro Kaneko
2014-10-16 5:23 ` Simon Horman
2014-10-18 14:55 ` Sergei Shtylyov
2014-10-14 6:24 ` [PATCH] media: soc_camera: rcar_vin: Add YUYV capture format support Yoshihiro Kaneko
2014-10-16 5:24 ` Simon Horman
2014-10-20 2:51 ` [PATCH] media: soc_camera: rcar_vin: Add DT support for r8a7793 and r8a7794 SoCs Yoshihiro Kaneko
2014-10-20 16:20 ` Simon Horman
2014-10-31 9:08 ` [PATCH] media: soc_camera: rcar_vin: Add BT.709 24-bit RGB888 input support Yoshihiro Kaneko
2014-10-31 13:00 ` Sergei Shtylyov
2015-12-13 15:27 ` [PATCH] media: soc_camera: rcar_vin: Add R-Car Gen3 support Yoshihiro Kaneko
2015-12-13 17:43 ` Sergei Shtylyov [this message]
2015-12-20 9:52 ` Yoshihiro Kaneko
2016-01-09 10:46 ` Guennadi Liakhovetski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=566DAE57.6030000@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=g.liakhovetski@gmx.de \
--cc=horms@verge.net.au \
--cc=linux-media@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=ykaneko0929@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).