From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Mon, 14 Dec 2015 17:03:21 +0000 Subject: Re: [PATCH/RFC 03/19] ARM: shmobile: gose: add i2c2 bus to device tree Message-Id: <566EF659.2010105@cogentembedded.com> List-Id: References: <1449802376-11301-1-git-send-email-horms+renesas@verge.net.au> <1449802376-11301-4-git-send-email-horms+renesas@verge.net.au> <566AB2A5.4090105@cogentembedded.com> <20151214021110.GD13945@verge.net.au> In-Reply-To: <20151214021110.GD13945@verge.net.au> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org On 12/14/2015 05:11 AM, Simon Horman wrote: >>> Activate i2c2 bus in r8a7793/gose device tree. >>> >>> Based on similar work for the r8a7791/koelsch by Wolfram Sang. >>> >>> Cc: Wolfram Sang >>> Signed-off-by: Simon Horman >>> --- >>> arch/arm/boot/dts/r8a7793-gose.dts | 19 +++++++++++++++++++ >>> 1 file changed, 19 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/r8a7793-gose.dts b/arch/arm/boot/dts/r8a7793-gose.dts >>> index 3e3122490650..9a71ff6d4474 100644 >>> --- a/arch/arm/boot/dts/r8a7793-gose.dts >>> +++ b/arch/arm/boot/dts/r8a7793-gose.dts >> [...] >>> @@ -135,3 +140,17 @@ >>> }; >>> }; >>> }; >>> + >>> +&i2c2 { >>> + pinctrl-0 = <&i2c2_pins>; >>> + pinctrl-names = "default"; >>> + >>> + status = "okay"; >>> + clock-frequency = <100000>; >>> + >>> + eeprom@50 { >>> + compatible = "renesas,24c02"; >> >> This is not a valid value -- the Renesas chip model is different from 24c02. > > I copied this value from r8a7791.dtsi. r8a7791-koelsch.dts, you mean? I remember there has been a discussion on this topic, and I then refrained from adding MAC address EEPROMs as a result. :-) > Looking at the schematic for gose (v100), koelsch (rev024) and porter (v300) > I see the following "R1EX24002ATAS0G#U0". Shall we update r8a7791 and > this patch to "renesas,24002" or leave things as is? What Geert has suggested seems the right thing to me. MBR, Sergei