* [PATCH net] ravb: Add disable 10base
@ 2015-12-13 15:15 Yoshihiro Kaneko
2015-12-13 17:17 ` Sergei Shtylyov
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Yoshihiro Kaneko @ 2015-12-13 15:15 UTC (permalink / raw)
To: netdev
Cc: David S. Miller, Sergei Shtylyov, Simon Horman, Magnus Damm,
linux-sh
From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
Ethernet AVB does not support 10 Mbps transfer speed.
Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
---
This patch is based on the master branch of David Miller's networking
tree.
drivers/net/ethernet/renesas/ravb_main.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
index b69e0c2..467d416 100644
--- a/drivers/net/ethernet/renesas/ravb_main.c
+++ b/drivers/net/ethernet/renesas/ravb_main.c
@@ -905,6 +905,9 @@ static int ravb_phy_init(struct net_device *ndev)
netdev_info(ndev, "limited PHY to 100Mbit/s\n");
}
+ /* 10BASE is not supported */
+ phydev->supported &= ~PHY_10BT_FEATURES;
+
netdev_info(ndev, "attached PHY %d (IRQ %d) to driver %s\n",
phydev->addr, phydev->irq, phydev->drv->name);
--
1.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH net] ravb: Add disable 10base
2015-12-13 15:15 [PATCH net] ravb: Add disable 10base Yoshihiro Kaneko
@ 2015-12-13 17:17 ` Sergei Shtylyov
2015-12-14 4:53 ` Simon Horman
2015-12-14 17:31 ` Sergei Shtylyov
2015-12-15 5:26 ` David Miller
2 siblings, 1 reply; 8+ messages in thread
From: Sergei Shtylyov @ 2015-12-13 17:17 UTC (permalink / raw)
To: Yoshihiro Kaneko, netdev
Cc: David S. Miller, Simon Horman, Magnus Damm, linux-sh
Hello.
On 12/13/2015 06:15 PM, Yoshihiro Kaneko wrote:
> From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
>
> Ethernet AVB does not support 10 Mbps transfer speed.
>
> Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
> ---
>
> This patch is based on the master branch of David Miller's networking
> tree.
>
> drivers/net/ethernet/renesas/ravb_main.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
> index b69e0c2..467d416 100644
> --- a/drivers/net/ethernet/renesas/ravb_main.c
> +++ b/drivers/net/ethernet/renesas/ravb_main.c
> @@ -905,6 +905,9 @@ static int ravb_phy_init(struct net_device *ndev)
> netdev_info(ndev, "limited PHY to 100Mbit/s\n");
> }
>
> + /* 10BASE is not supported */
> + phydev->supported &= ~PHY_10BT_FEATURES;
> +
Perhaps we need phy_set_min_speed() in addition to phy_set_max_speed()?
MBR, Sergei
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH net] ravb: Add disable 10base
2015-12-13 17:17 ` Sergei Shtylyov
@ 2015-12-14 4:53 ` Simon Horman
2015-12-14 18:49 ` Florian Fainelli
0 siblings, 1 reply; 8+ messages in thread
From: Simon Horman @ 2015-12-14 4:53 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: Yoshihiro Kaneko, netdev, David S. Miller, Magnus Damm, linux-sh,
Florian Fainelli
[Cc Florian]
On Sun, Dec 13, 2015 at 08:17:48PM +0300, Sergei Shtylyov wrote:
> Hello.
>
> On 12/13/2015 06:15 PM, Yoshihiro Kaneko wrote:
>
> >From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
> >
> >Ethernet AVB does not support 10 Mbps transfer speed.
> >
> >Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
> >Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
> >---
> >
> >This patch is based on the master branch of David Miller's networking
> >tree.
> >
> > drivers/net/ethernet/renesas/ravb_main.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> >diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
> >index b69e0c2..467d416 100644
> >--- a/drivers/net/ethernet/renesas/ravb_main.c
> >+++ b/drivers/net/ethernet/renesas/ravb_main.c
> >@@ -905,6 +905,9 @@ static int ravb_phy_init(struct net_device *ndev)
> > netdev_info(ndev, "limited PHY to 100Mbit/s\n");
> > }
> >
> >+ /* 10BASE is not supported */
> >+ phydev->supported &= ~PHY_10BT_FEATURES;
> >+
>
> Perhaps we need phy_set_min_speed() in addition to phy_set_max_speed()?
FWIW, as the person who added phy_set_max_speed(), I think
that is sounds like a good idea.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net] ravb: Add disable 10base
2015-12-14 4:53 ` Simon Horman
@ 2015-12-14 18:49 ` Florian Fainelli
0 siblings, 0 replies; 8+ messages in thread
From: Florian Fainelli @ 2015-12-14 18:49 UTC (permalink / raw)
To: Simon Horman, Sergei Shtylyov
Cc: Yoshihiro Kaneko, netdev, David S. Miller, Magnus Damm, linux-sh
On 13/12/15 20:53, Simon Horman wrote:
> [Cc Florian]
>
> On Sun, Dec 13, 2015 at 08:17:48PM +0300, Sergei Shtylyov wrote:
>> Hello.
>>
>> On 12/13/2015 06:15 PM, Yoshihiro Kaneko wrote:
>>
>>> From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
>>>
>>> Ethernet AVB does not support 10 Mbps transfer speed.
>>>
>>> Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
>>> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
>>> ---
>>>
>>> This patch is based on the master branch of David Miller's networking
>>> tree.
>>>
>>> drivers/net/ethernet/renesas/ravb_main.c | 3 +++
>>> 1 file changed, 3 insertions(+)
>>>
>>> diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
>>> index b69e0c2..467d416 100644
>>> --- a/drivers/net/ethernet/renesas/ravb_main.c
>>> +++ b/drivers/net/ethernet/renesas/ravb_main.c
>>> @@ -905,6 +905,9 @@ static int ravb_phy_init(struct net_device *ndev)
>>> netdev_info(ndev, "limited PHY to 100Mbit/s\n");
>>> }
>>>
>>> + /* 10BASE is not supported */
>>> + phydev->supported &= ~PHY_10BT_FEATURES;
>>> +
>>
>> Perhaps we need phy_set_min_speed() in addition to phy_set_max_speed()?
>
> FWIW, as the person who added phy_set_max_speed(), I think
> that is sounds like a good idea.
I am not opposed to the idea, but so far, it seems like setting the
minimum supported speed was a little less frequent than setting the
maximum speed. Feel free to submit a patch though if you think/know
there are other drivers potentially using this.
--
Florian
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net] ravb: Add disable 10base
2015-12-13 15:15 [PATCH net] ravb: Add disable 10base Yoshihiro Kaneko
2015-12-13 17:17 ` Sergei Shtylyov
@ 2015-12-14 17:31 ` Sergei Shtylyov
2015-12-14 18:49 ` Florian Fainelli
2015-12-15 5:26 ` David Miller
2 siblings, 1 reply; 8+ messages in thread
From: Sergei Shtylyov @ 2015-12-14 17:31 UTC (permalink / raw)
To: Yoshihiro Kaneko, netdev
Cc: David S. Miller, Simon Horman, Magnus Damm, linux-sh
Hello.
On 12/13/2015 06:15 PM, Yoshihiro Kaneko wrote:
> From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
>
> Ethernet AVB does not support 10 Mbps transfer speed.
>
> Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
> ---
>
> This patch is based on the master branch of David Miller's networking
> tree.
>
> drivers/net/ethernet/renesas/ravb_main.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
> index b69e0c2..467d416 100644
> --- a/drivers/net/ethernet/renesas/ravb_main.c
> +++ b/drivers/net/ethernet/renesas/ravb_main.c
> @@ -905,6 +905,9 @@ static int ravb_phy_init(struct net_device *ndev)
> netdev_info(ndev, "limited PHY to 100Mbit/s\n");
> }
>
> + /* 10BASE is not supported */
> + phydev->supported &= ~PHY_10BT_FEATURES;
I wonder if we should also modify 'phydev->advertising' like
phy_set_max_speed() does...
MBR, Sergei
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH net] ravb: Add disable 10base
2015-12-14 17:31 ` Sergei Shtylyov
@ 2015-12-14 18:49 ` Florian Fainelli
2015-12-15 11:41 ` Sergei Shtylyov
0 siblings, 1 reply; 8+ messages in thread
From: Florian Fainelli @ 2015-12-14 18:49 UTC (permalink / raw)
To: Sergei Shtylyov, Yoshihiro Kaneko, netdev
Cc: David S. Miller, Simon Horman, Magnus Damm, linux-sh
On 14/12/15 09:31, Sergei Shtylyov wrote:
> Hello.
>
> On 12/13/2015 06:15 PM, Yoshihiro Kaneko wrote:
>
>> From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
>>
>> Ethernet AVB does not support 10 Mbps transfer speed.
>>
>> Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
>> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
>> ---
>>
>> This patch is based on the master branch of David Miller's networking
>> tree.
>>
>> drivers/net/ethernet/renesas/ravb_main.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/net/ethernet/renesas/ravb_main.c
>> b/drivers/net/ethernet/renesas/ravb_main.c
>> index b69e0c2..467d416 100644
>> --- a/drivers/net/ethernet/renesas/ravb_main.c
>> +++ b/drivers/net/ethernet/renesas/ravb_main.c
>> @@ -905,6 +905,9 @@ static int ravb_phy_init(struct net_device *ndev)
>> netdev_info(ndev, "limited PHY to 100Mbit/s\n");
>> }
>>
>> + /* 10BASE is not supported */
>> + phydev->supported &= ~PHY_10BT_FEATURES;
>
> I wonder if we should also modify 'phydev->advertising' like
> phy_set_max_speed() does...
Yes, this is a good idea. If your PHY driver uses genphy_config_advert()
this is taken care of for you, but in case you have a buggy PHY driver,
you should just do this yourself here.
--
Florian
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net] ravb: Add disable 10base
2015-12-14 18:49 ` Florian Fainelli
@ 2015-12-15 11:41 ` Sergei Shtylyov
0 siblings, 0 replies; 8+ messages in thread
From: Sergei Shtylyov @ 2015-12-15 11:41 UTC (permalink / raw)
To: Florian Fainelli, Yoshihiro Kaneko, netdev
Cc: David S. Miller, Simon Horman, Magnus Damm, linux-sh
Hello.
On 12/14/2015 9:49 PM, Florian Fainelli wrote:
>>> From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
>>>
>>> Ethernet AVB does not support 10 Mbps transfer speed.
>>>
>>> Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
>>> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
>>> ---
>>>
>>> This patch is based on the master branch of David Miller's networking
>>> tree.
>>>
>>> drivers/net/ethernet/renesas/ravb_main.c | 3 +++
>>> 1 file changed, 3 insertions(+)
>>>
>>> diff --git a/drivers/net/ethernet/renesas/ravb_main.c
>>> b/drivers/net/ethernet/renesas/ravb_main.c
>>> index b69e0c2..467d416 100644
>>> --- a/drivers/net/ethernet/renesas/ravb_main.c
>>> +++ b/drivers/net/ethernet/renesas/ravb_main.c
>>> @@ -905,6 +905,9 @@ static int ravb_phy_init(struct net_device *ndev)
>>> netdev_info(ndev, "limited PHY to 100Mbit/s\n");
>>> }
>>>
>>> + /* 10BASE is not supported */
>>> + phydev->supported &= ~PHY_10BT_FEATURES;
>>
>> I wonder if we should also modify 'phydev->advertising' like
>> phy_set_max_speed() does...
>
> Yes, this is a good idea. If your PHY driver uses genphy_config_advert()
> this is taken care of for you, but in case you have a buggy PHY driver,
> you should just do this yourself here.
OK, drivers/net/phy/micrel.c uses it for almost all chips.
MBR, Sergei
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net] ravb: Add disable 10base
2015-12-13 15:15 [PATCH net] ravb: Add disable 10base Yoshihiro Kaneko
2015-12-13 17:17 ` Sergei Shtylyov
2015-12-14 17:31 ` Sergei Shtylyov
@ 2015-12-15 5:26 ` David Miller
2 siblings, 0 replies; 8+ messages in thread
From: David Miller @ 2015-12-15 5:26 UTC (permalink / raw)
To: ykaneko0929; +Cc: netdev, sergei.shtylyov, horms, magnus.damm, linux-sh
From: Yoshihiro Kaneko <ykaneko0929@gmail.com>
Date: Mon, 14 Dec 2015 00:15:58 +0900
> From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
>
> Ethernet AVB does not support 10 Mbps transfer speed.
>
> Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2015-12-15 11:41 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-13 15:15 [PATCH net] ravb: Add disable 10base Yoshihiro Kaneko
2015-12-13 17:17 ` Sergei Shtylyov
2015-12-14 4:53 ` Simon Horman
2015-12-14 18:49 ` Florian Fainelli
2015-12-14 17:31 ` Sergei Shtylyov
2015-12-14 18:49 ` Florian Fainelli
2015-12-15 11:41 ` Sergei Shtylyov
2015-12-15 5:26 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).