From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Tue, 15 Dec 2015 11:41:40 +0000 Subject: Re: [PATCH net] ravb: Add disable 10base Message-Id: <566FFC74.6060407@cogentembedded.com> List-Id: References: <1450019758-32710-1-git-send-email-ykaneko0929@gmail.com> <566EFCEF.2030200@cogentembedded.com> <566F0F21.6040504@gmail.com> In-Reply-To: <566F0F21.6040504@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Florian Fainelli , Yoshihiro Kaneko , netdev@vger.kernel.org Cc: "David S. Miller" , Simon Horman , Magnus Damm , linux-sh@vger.kernel.org Hello. On 12/14/2015 9:49 PM, Florian Fainelli wrote: >>> From: Kazuya Mizuguchi >>> >>> Ethernet AVB does not support 10 Mbps transfer speed. >>> >>> Signed-off-by: Kazuya Mizuguchi >>> Signed-off-by: Yoshihiro Kaneko >>> --- >>> >>> This patch is based on the master branch of David Miller's networking >>> tree. >>> >>> drivers/net/ethernet/renesas/ravb_main.c | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/drivers/net/ethernet/renesas/ravb_main.c >>> b/drivers/net/ethernet/renesas/ravb_main.c >>> index b69e0c2..467d416 100644 >>> --- a/drivers/net/ethernet/renesas/ravb_main.c >>> +++ b/drivers/net/ethernet/renesas/ravb_main.c >>> @@ -905,6 +905,9 @@ static int ravb_phy_init(struct net_device *ndev) >>> netdev_info(ndev, "limited PHY to 100Mbit/s\n"); >>> } >>> >>> + /* 10BASE is not supported */ >>> + phydev->supported &= ~PHY_10BT_FEATURES; >> >> I wonder if we should also modify 'phydev->advertising' like >> phy_set_max_speed() does... > > Yes, this is a good idea. If your PHY driver uses genphy_config_advert() > this is taken care of for you, but in case you have a buggy PHY driver, > you should just do this yourself here. OK, drivers/net/phy/micrel.c uses it for almost all chips. MBR, Sergei