* [PATCH] extcon: max3355: kill unneeded #include's
@ 2015-12-20 18:31 Sergei Shtylyov
2015-12-21 2:42 ` Chanwoo Choi
0 siblings, 1 reply; 2+ messages in thread
From: Sergei Shtylyov @ 2015-12-20 18:31 UTC (permalink / raw)
To: myungjoo.ham, cw00.choi, linux-kernel; +Cc: linux-usb, linux-sh
Some #include's weren't needed from the start, some are left overs from the
earlier driver versions... Kill 'em all! :-)
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
The patch is against the 'extcon-next' branch of the 'extcon.git' repo.
If possible, please fold this patch into the main MAX3355 driver patch.
drivers/extcon/extcon-max3355.c | 5 -----
1 file changed, 5 deletions(-)
Index: extcon/drivers/extcon/extcon-max3355.c
=================================--- extcon.orig/drivers/extcon/extcon-max3355.c
+++ extcon/drivers/extcon/extcon-max3355.c
@@ -11,14 +11,9 @@
#include <linux/extcon.h>
#include <linux/gpio.h>
-#include <linux/init.h>
#include <linux/interrupt.h>
-#include <linux/kernel.h>
#include <linux/module.h>
-#include <linux/of_gpio.h>
#include <linux/platform_device.h>
-#include <linux/slab.h>
-#include <linux/workqueue.h>
struct max3355_data {
struct extcon_dev *edev;
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] extcon: max3355: kill unneeded #include's
2015-12-20 18:31 [PATCH] extcon: max3355: kill unneeded #include's Sergei Shtylyov
@ 2015-12-21 2:42 ` Chanwoo Choi
0 siblings, 0 replies; 2+ messages in thread
From: Chanwoo Choi @ 2015-12-21 2:42 UTC (permalink / raw)
To: Sergei Shtylyov, myungjoo.ham, linux-kernel; +Cc: linux-usb, linux-sh
On 2015년 12월 21일 03:31, Sergei Shtylyov wrote:
> Some #include's weren't needed from the start, some are left overs from the
> earlier driver versions... Kill 'em all! :-)
I don't prefer following expression. I think you should write the description
to maintain the formal style on the next.
- "... Kill 'em all! :-) "
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> ---
> The patch is against the 'extcon-next' branch of the 'extcon.git' repo.
> If possible, please fold this patch into the main MAX3355 driver patch.
>
> drivers/extcon/extcon-max3355.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> Index: extcon/drivers/extcon/extcon-max3355.c
> =================================> --- extcon.orig/drivers/extcon/extcon-max3355.c
> +++ extcon/drivers/extcon/extcon-max3355.c
> @@ -11,14 +11,9 @@
>
> #include <linux/extcon.h>
> #include <linux/gpio.h>
> -#include <linux/init.h>
> #include <linux/interrupt.h>
> -#include <linux/kernel.h>
> #include <linux/module.h>
> -#include <linux/of_gpio.h>
> #include <linux/platform_device.h>
> -#include <linux/slab.h>
> -#include <linux/workqueue.h>
>
> struct max3355_data {
> struct extcon_dev *edev;
>
I combine it on original patch.
Thanks,
Chanwoo Choi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-12-21 2:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-20 18:31 [PATCH] extcon: max3355: kill unneeded #include's Sergei Shtylyov
2015-12-21 2:42 ` Chanwoo Choi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).