From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Fri, 25 Dec 2015 23:45:55 +0000 Subject: Re: [PATCH v5 09/14] ARM: shmobile: koelsch: Enable DU device in DT Message-Id: <567DD533.7000001@cogentembedded.com> List-Id: References: <1414332679-15497-10-git-send-email-laurent.pinchart+renesas@ideasonboard.com> In-Reply-To: <1414332679-15497-10-git-send-email-laurent.pinchart+renesas@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-sh@vger.kernel.org Hello. On 12/24/2015 10:54 PM, Sergei Shtylyov wrote: >> Specify the DU output topology, enable the DU device and configure the >> related pins. >> >> Signed-off-by: Laurent Pinchart >> --- >> arch/arm/boot/dts/r8a7791-koelsch.dts | 16 +++++++++++++--- >> 1 file changed, 13 insertions(+), 3 deletions(-) >> >> diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts >> b/arch/arm/boot/dts/r8a7791-koelsch.dts >> index 53184637f160..0402c498b05b 100644 >> --- a/arch/arm/boot/dts/r8a7791-koelsch.dts >> +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts >> @@ -212,14 +212,24 @@ >> }; >> }; >> >> +&du { >> + pinctrl-0 = <&du_pins>; >> + pinctrl-names = "default"; >> + status = "okay"; >> + >> + ports { >> + port@1 { >> + lvds_connector: endpoint { > > I don't understand what this unreferenced label achieves. Also, the > Koelsch schematics tells me LVDS is connected to DU0, not DU1... OK, figured it out now! However in the absence of #include for a LCD panel this still makes little sense. > [...] MBR, Sergei