linux-sh.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dirk Behme <dirk.behme@de.bosch.com>
To: linux-sh@vger.kernel.org
Subject: Re: [RFC] clk: shmobile: r8a7795: Add SD divider support
Date: Wed, 27 Jan 2016 13:14:01 +0000	[thread overview]
Message-ID: <56A8C299.5060702@de.bosch.com> (raw)
In-Reply-To: <1453465586-12807-1-git-send-email-dirk.behme@de.bosch.com>

On 27.01.2016 08:14, Wolfram Sang wrote:
> On Fri, Jan 22, 2016 at 01:26:26PM +0100, Dirk Behme wrote:
>> From: Takeshi Kihara <takeshi.kihara.df@renesas.com>
>>
>> This patch adds SD[0..3] clock divider support for R-Car Gen3 SoC.
>>
>> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
>> Signed-off-by: Dirk Behme <dirk.behme@de.bosch.com>
>
> So, I tested this patch and it basically works. I say basically because
> the SDHI code currently does not change the clock rate, only
> en-/disables it. UHS support will need to change the clock later.
>
> One thing I noticed: SD0-2 are 50MHz like the docs say. SD3 is 200MHz
> and I couldn't find a reason for that when having a glimpse. Dirk, can
> you check?


Having the clock patch applied on top of your renesas/v8-sdhi branch [1] 
I get

root@salvator-x:/sys/kernel/debug/clk# cat clk_summary
    clock             enable_cnt  prepare_cnt        rate
--------------------------------------------------------
...
     .main                     1            1     8333333
     ...
        .pll1                  1            1  1599999936
           .pll1_div2          2            2   799999968
              hdmi             0            0    24999999
                 hdmi0         0            0    24999999
                 hdmi1         0            0    24999999
              cl               0            0    16666666
              sd3              0            0    99999996
                 sdif3         0            0    99999996
              sd2              0            0    99999996
                 sdif2         0            0    99999996
              sd1              0            0    49999998
                 sdif1         0            0    49999998
              sd0              0            0    49999998
                 sdif0         0            0    49999998


Best regards

Dirk

[1] 
https://github.com/dirkbehme/linux-renesas-rcar-gen3/commits/wsa-renesas/v8-sdhi

  parent reply	other threads:[~2016-01-27 13:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-22 12:26 [RFC] clk: shmobile: r8a7795: Add SD divider support Dirk Behme
2016-01-25  8:59 ` Geert Uytterhoeven
2016-01-25  9:11 ` Dirk Behme
2016-01-25 19:23 ` Wolfram Sang
2016-01-27  7:14 ` Wolfram Sang
2016-01-27  8:43 ` Geert Uytterhoeven
2016-01-27  9:01 ` Dirk Behme
2016-01-27 13:14 ` Dirk Behme [this message]
2016-01-29  8:14 ` Wolfram Sang
2016-01-29  8:29 ` Dirk Behme

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56A8C299.5060702@de.bosch.com \
    --to=dirk.behme@de.bosch.com \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).