From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 2/3] ARM: shmobile: r8a7791: add MSTP10 support on DTSI
Date: Mon, 08 Feb 2016 13:54:50 +0000 [thread overview]
Message-ID: <56B89E2A.3050309@cogentembedded.com> (raw)
In-Reply-To: <1387998730-6012-3-git-send-email-valentine.barshak@cogentembedded.com>
On 02/08/2016 03:39 AM, Kuninori Morimoto wrote:
>>> + mstp10_clks: mstp10_clks@e6150998 {
>>> + compatible = "renesas,r8a7791-mstp-clocks", "renesas,cpg-mstp-clocks";
>>> + reg = <0 0xe6150998 0 4>, <0 0xe61509a8 0 4>;
>>> + clocks = <&p_clk>,
>>> + <&p_clk>, <&p_clk>, <&p_clk>, <&p_clk>, <&p_clk>,
>>> + <&p_clk>, <&p_clk>, <&p_clk>, <&p_clk>, <&p_clk>,
>>
>> But don't SSI[0-9] clocks all depend on SSI(all)? Shouldn't the
>> above 10 entries be
>> <&mstp10_clks R8A7791_CLK_SSI_ALL> like it was done to SCU(all)?
>
> Basically, you are correct.
> I forgot detail, but SSI(all) will be enabled by normal pm_runtime_xxx().
> And it had clock enable order dependency before.
> (I think it was solved by using clock-indices feature)
Not sure I understand.
> It is not very correct indeed, but basically no problem I think.
> But do you have some issues ?
Just was looking at the manual writing the R8A7794 device tree audio
support and this inconsistency came up.
MBR, Sergei
prev parent reply other threads:[~2016-02-08 13:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-25 19:12 [PATCH 2/3] arm: shmobile: r8a7791: Add I2C clocks Valentine Barshak
2013-12-25 19:36 ` [PATCH 2/3] arm: shmobile: r8a7791: Add VIN clocks Valentine Barshak
2013-12-26 15:37 ` Valentine Barshak
2014-06-12 4:44 ` [PATCH 2/3] ARM: shmobile: r8a7791: add MSTP10 support on DTSI Kuninori Morimoto
2014-06-12 6:46 ` Geert Uytterhoeven
2014-06-13 7:47 ` Simon Horman
2015-01-27 9:13 ` [PATCH 2/3] ARM: shmobile: r8a7791: Add IPMMU DT nodes Laurent Pinchart
2016-01-28 20:38 ` [PATCH 2/3] ARM: shmobile: r8a7791: add MSTP10 support on DTSI Sergei Shtylyov
2016-02-08 0:39 ` Kuninori Morimoto
2016-02-08 13:54 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B89E2A.3050309@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).