From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Hurley Date: Fri, 29 Apr 2016 15:38:09 +0000 Subject: Re: [PATCH v2 03/11] serial: sh-sci: Always set TIOCM_CTS in .get_mctrl() callback Message-Id: <57237FE1.8030200@hurleysoftware.com> List-Id: References: <1461934714-18681-1-git-send-email-geert+renesas@glider.be> <1461934714-18681-4-git-send-email-geert+renesas@glider.be> In-Reply-To: <1461934714-18681-4-git-send-email-geert+renesas@glider.be> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Geert Uytterhoeven , Greg Kroah-Hartman Cc: Jiri Slaby , Magnus Damm , Laurent Pinchart , Yoshinori Sato , linux-serial@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org On 04/29/2016 05:58 AM, Geert Uytterhoeven wrote: > Documentation/serial/driver clearly states: > > If the port does not support CTS, DCD or DSR, the driver should > indicate that the signal is permanently active. > > Hence always set TIOCM_CTS, as we currently don't look at the CTS > hardware line state at all. > > FWIW, this fixes the transmit path when hardware-assisted flow control > is enabled, and userspace enables CRTSCTS. > The receive path is still broken, as RTS is never asserted. Reviewed-by: Peter Hurley