From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Phil Edworthy <phil.edworthy@renesas.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
Simon Horman <horms+renesas@verge.net.au>,
Linux-SH <linux-sh@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sh-pfc: r8a7791: Fix definition of MOD_SEL3
Date: Tue, 22 Apr 2014 16:39:29 +0000 [thread overview]
Message-ID: <5799320.HL6Fc0SWev@avalon> (raw)
In-Reply-To: <1398184685-31670-1-git-send-email-phil.edworthy@renesas.com>
Hi Phil,
Thank you for the patch.
On Tuesday 22 April 2014 17:38:05 Phil Edworthy wrote:
> There is a missing 0 entry from the MOD_SEL3 table.
>
> Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/pinctrl/sh-pfc/pfc-r8a7791.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7791.c
> b/drivers/pinctrl/sh-pfc/pfc-r8a7791.c index 56f62dc..a823b5b 100644
> --- a/drivers/pinctrl/sh-pfc/pfc-r8a7791.c
> +++ b/drivers/pinctrl/sh-pfc/pfc-r8a7791.c
> @@ -5305,7 +5305,7 @@ static const struct pinmux_cfg_reg
> pinmux_config_regs[] = { /* SEL_SCIF3 [2] */
> FN_SEL_SCIF3_0, FN_SEL_SCIF3_1, FN_SEL_SCIF3_2, FN_SEL_SCIF3_3,
> /* SEL_IEB [2] */
> - FN_SEL_IEB_0, FN_SEL_IEB_1, FN_SEL_IEB_2,
> + FN_SEL_IEB_0, FN_SEL_IEB_1, FN_SEL_IEB_2, 0,
> /* SEL_MMC [1] */
> FN_SEL_MMC_0, FN_SEL_MMC_1,
> /* SEL_SCIF5 [1] */
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2014-04-22 16:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-22 16:38 [PATCH] sh-pfc: r8a7791: Fix definition of MOD_SEL3 Phil Edworthy
2014-04-22 16:39 ` Laurent Pinchart [this message]
2014-04-23 14:10 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5799320.HL6Fc0SWev@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=horms+renesas@verge.net.au \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=phil.edworthy@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).