SUPERH platform development
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 1/6] sh-pfc: r8a7740: Add SCIFA1 data group
Date: Thu, 04 Apr 2013 14:00:59 +0000	[thread overview]
Message-ID: <5911848.QnMCxJT6TJ@avalon> (raw)
In-Reply-To: <1365083144-16085-1-git-send-email-hechtb+renesas@gmail.com>

Hi Bastian,

Thanks for the patch.

On Thursday 04 April 2013 15:45:39 Bastian Hecht wrote:
> Add SCIFA1 as preparation to switch to pinctrl in board files.
> 
> Signed-off-by: Bastian Hecht <hechtb+renesas@gmail.com>
> ---
>  drivers/pinctrl/sh-pfc/pfc-r8a7740.c |   15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7740.c
> b/drivers/pinctrl/sh-pfc/pfc-r8a7740.c index bbd87d2..6f62ab5 100644
> --- a/drivers/pinctrl/sh-pfc/pfc-r8a7740.c
> +++ b/drivers/pinctrl/sh-pfc/pfc-r8a7740.c
> @@ -1658,6 +1658,14 @@ static struct sh_pfc_pin pinmux_pins[] = {
>  	GPIO_PORT_ALL(),
>  };
> 
> +/* - SCIFA1 ------------------------------------------------------------ */
> +static const unsigned int scifa1_data_pins[] = {
> +	/* RXD, TXD */
> +	195, 196,
> +};
> +static const unsigned int scifa1_data_mux[] = {
> +	SCIFA1_RXD_MARK, SCIFA1_TXD_MARK,
> +};

Please keep the entries alphabetically sorted (here and below). The patch 
looks good otherwise.

>  /* - LCD0 -------------------------------------------------------------- */
> static const unsigned int lcd0_data8_pins[] = {
>  	/* D[0:7] */
> @@ -2054,6 +2062,7 @@ static const unsigned int sdhi2_wp_1_mux[] = {
>  };
> 
>  static const struct sh_pfc_pin_group pinmux_groups[] = {
> +	SH_PFC_PIN_GROUP(scifa1_data),
>  	SH_PFC_PIN_GROUP(lcd0_data8),
>  	SH_PFC_PIN_GROUP(lcd0_data9),
>  	SH_PFC_PIN_GROUP(lcd0_data12),
> @@ -2103,7 +2112,12 @@ static const struct sh_pfc_pin_group pinmux_groups[]
> = { SH_PFC_PIN_GROUP(sdhi2_wp_1),
>  };
> 
> +static const char * const scifa1_groups[] = {
> +	"scifa1_data",
> +};
> +
>  static const char * const lcd0_groups[] = {
> +	"scifa1_data",
>  	"lcd0_data8",
>  	"lcd0_data9",
>  	"lcd0_data12",
> @@ -2169,6 +2183,7 @@ static const char * const sdhi2_groups[] = {
>  };
> 
>  static const struct sh_pfc_function pinmux_functions[] = {
> +	SH_PFC_FUNCTION(scifa1),
>  	SH_PFC_FUNCTION(lcd0),
>  	SH_PFC_FUNCTION(lcd1),
>  	SH_PFC_FUNCTION(mmc0),
-- 
Regards,

Laurent Pinchart


  reply	other threads:[~2013-04-04 14:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-04 13:45 [PATCH 1/6] sh-pfc: r8a7740: Add SCIFA1 data group Bastian Hecht
2013-04-04 14:00 ` Laurent Pinchart [this message]
2013-04-04 16:00 ` Bastian Hecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5911848.QnMCxJT6TJ@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox