From: David Hildenbrand <david@redhat.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-ia64@vger.kernel.org, David Hildenbrand <david@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Dave Hansen <dave.hansen@linux.intel.com>,
platform-driver-x86@vger.kernel.org,
Linux MM <linux-mm@kvack.org>, Will Deacon <will@kernel.org>,
Christoph Hellwig <hch@lst.de>,
linux-s390 <linux-s390@vger.kernel.org>,
Linux-sh <linux-sh@vger.kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Borislav Petkov <bp@alien8.de>, Andy Lutomirski <luto@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Michal Hocko <mhocko@kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Eric Badger <ebadger@gigaio.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Logan Gunthorpe <logang@deltatee.com>
Subject: Re: [PATCH v2 2/8] mm/memory_hotplug: Rename mhp_restrictions to mhp_modifiers
Date: Wed, 08 Jan 2020 19:08:07 +0000 [thread overview]
Message-ID: <5D5ED235-EB67-4072-8CCA-C046B7EC031C@redhat.com> (raw)
In-Reply-To: <CAPcyv4hdpMs5om4_VrYUz98aWDJ9eRhj7WJr312Jwn6LCmAm9Q@mail.gmail.com>
> Am 08.01.2020 um 20:00 schrieb Dan Williams <dan.j.williams@intel.com>:
>
> On Wed, Jan 8, 2020 at 9:17 AM Logan Gunthorpe <logang@deltatee.com> wrote:
>>
>>
>>
>>> On 2020-01-08 5:28 a.m., David Hildenbrand wrote:
>>> On 07.01.20 21:59, Logan Gunthorpe wrote:
>>>> The mhp_restrictions struct really doesn't specify anything resembling
>>>> a restriction anymore so rename it to be mhp_modifiers.
>>>
>>> I wonder if something like "mhp_params" would be even better. It's
>>> essentially just a way to avoid changing call chains rough-out all archs
>>> whenever we want to add a new parameter.
>>
>> Sure, that does sound a bit nicer to me. I can change it for v3.
>
> Oh, I was just about to chime in to support "modifiers" because I
> would expect all parameters to folded into a "params" struct. The
> modifiers seem to be limited to the set of items that are only
> considered in a non-default / expert memory hotplug use cases.
>
It‘s a set of extended parameters I‘d say.
next prev parent reply other threads:[~2020-01-08 19:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 20:59 [PATCH v2 0/8] Allow setting caching mode in arch_add_memory() for P2PDMA Logan Gunthorpe
2020-01-07 20:59 ` [PATCH v2 1/8] mm/memory_hotplug: Drop the flags field from struct mhp_restrictions Logan Gunthorpe
2020-01-08 12:27 ` David Hildenbrand
2020-01-07 20:59 ` [PATCH v2 2/8] mm/memory_hotplug: Rename mhp_restrictions to mhp_modifiers Logan Gunthorpe
2020-01-08 12:28 ` David Hildenbrand
2020-01-08 17:16 ` Logan Gunthorpe
2020-01-08 18:59 ` Dan Williams
2020-01-08 19:08 ` David Hildenbrand [this message]
2020-01-08 19:13 ` Dan Williams
2020-01-08 19:29 ` Logan Gunthorpe
2020-01-07 20:59 ` [PATCH v2 3/8] x86/mm: Thread pgprot_t through init_memory_mapping() Logan Gunthorpe
2020-01-07 20:59 ` [PATCH v2 4/8] x86/mm: Introduce _set_memory_prot() Logan Gunthorpe
2020-01-07 20:59 ` [PATCH v2 5/8] powerpc/mm: Thread pgprot_t through create_section_mapping() Logan Gunthorpe
2020-01-07 20:59 ` [PATCH v2 6/8] s390/mm: Thread pgprot_t through vmem_add_mapping() Logan Gunthorpe
2020-01-08 12:43 ` David Hildenbrand
2020-01-08 17:20 ` Logan Gunthorpe
2020-01-07 20:59 ` [PATCH v2 7/8] mm/memory_hotplug: Add pgprot_t to mhp_modifiers Logan Gunthorpe
2020-01-08 12:39 ` David Hildenbrand
2020-01-08 17:17 ` Logan Gunthorpe
2020-01-08 12:42 ` Michal Hocko
2020-01-08 17:18 ` Logan Gunthorpe
2020-01-07 20:59 ` [PATCH v2 8/8] mm/memremap: Set caching mode for PCI P2PDMA memory to WC Logan Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5D5ED235-EB67-4072-8CCA-C046B7EC031C@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=ebadger@gigaio.com \
--cc=hch@lst.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=logang@deltatee.com \
--cc=luto@kernel.org \
--cc=mhocko@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).