From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH v2 12/17] clk: shmobile: mstp: Fix the is_enabled() operation
Date: Tue, 13 May 2014 10:22:04 +0000 [thread overview]
Message-ID: <6169201.Ty7rNI3ZDf@avalon> (raw)
In-Reply-To: <1397565253-22741-13-git-send-email-geert+renesas@glider.be>
On Tuesday 13 May 2014 08:47:29 Geert Uytterhoeven wrote:
> On Tue, May 13, 2014 at 12:20 AM, Laurent Pinchart wrote:
> > On Tuesday 15 April 2014 14:34:08 Geert Uytterhoeven wrote:
> >> From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> >>
> >> The MSTP[SC]R registers have clock stop bits, not clock enable bits. The
> >> bit value should thus be inverted in the is_enabled() operation.
> >>
> >> Signed-off-by: Laurent Pinchart
> >> <laurent.pinchart+renesas@ideasonboard.com>
> >> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >> Cc: Mike Turquette <mturquette@linaro.org>
> >> ---
> >> This depends on the actual fixes, so either we need Mike's ack, or this
> >> has to wait until the fixes have landed in mainline.
> >
> > What's the status of this patch ? Do you still carry it in your tree and
> > plan to push it upstream at some point ?
>
> Yes, I still have it locally.
>
> It depends on "[PATCH v4] drivers: sh: compile drivers/sh/pm_runtime.c
> if ARCH_SHMOBILE_MULTI", so we have to wait until that one hits
> mainline.
>
> I think the only ill effects of not having it is that some clocks may not be
> disabled properly?
Correct. It's not so urgent, I was just going through my pending patches
yesterday to make sure none got forgotten.
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2014-05-13 10:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-15 12:34 [PATCH v2 12/17] clk: shmobile: mstp: Fix the is_enabled() operation Geert Uytterhoeven
2014-05-12 22:20 ` Laurent Pinchart
2014-05-13 6:47 ` Geert Uytterhoeven
2014-05-13 10:22 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6169201.Ty7rNI3ZDf@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).