From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Date: Thu, 15 Jan 2015 20:34:29 +0000 Subject: Re: [PATCH v2 2/2] input: adxl34x: Add OF match support Message-Id: <6357346.RjFSG892rq@avalon> List-Id: References: <1421333655-31029-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <20150115185431.GG33214@dtor-ws> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Geert Uytterhoeven Cc: Dmitry Torokhov , Laurent Pinchart , "linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Linux I2C , Linux-sh list , Wolfram Sang On Thursday 15 January 2015 21:00:37 Geert Uytterhoeven wrote: > On Thu, Jan 15, 2015 at 7:54 PM, Dmitry Torokhov wrote: > > I still do not understand what we are trying to fix here. Why is > > "adi,adxl34x" compatible string no good anymore? If we start using exact > > models and the physical device does not match do we abort probe? What is > > the problem that we are solving here? > > Because there's no guarantee that the driver actually supports all > "adi,adxl34" with = 0..9, some of which don't exist yet. That's one of the reasons. Another one is that the adxl34x driver won't match DT nodes that list the "adi,adxl34x" compatible value in positions other than the first. -- Regards, Laurent Pinchart