From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 5/6] dmaengine: rcar-dmac: Add Renesas R-Car Gen2 DMA Controller (DMAC) driver
Date: Wed, 06 Aug 2014 15:36:39 +0000 [thread overview]
Message-ID: <6487467.jFjtprcHSy@avalon> (raw)
In-Reply-To: <7ae1dbb4f4a79a529250600cc2eeb7c31a644938.1406766014.git.horms+renesas@verge.net.au>
Hi Geert,
On Wednesday 06 August 2014 14:47:39 Geert Uytterhoeven wrote:
> On Thu, Jul 31, 2014 at 2:34 AM, Simon Horman wrote:
> >
> > +static struct dma_async_tx_descriptor *
> > +rcar_dmac_prep_dma_cyclic(struct dma_chan *chan, dma_addr_t buf_addr,
> > + size_t buf_len, size_t period_len,
> > + enum dma_transfer_direction dir, unsigned long
> > flags, + void *context)
>
> BTW, the "context" parameter should be removed, as Laurent's independent
> patch to remove it everywhere else has hit slave-dma/next"
>
> drivers/dma/sh/rcar-dmac.c: In function 'rcar_dmac_probe':
> drivers/dma/sh/rcar-dmac.c:1462:33: warning: assignment from
> incompatible pointer type
> engine->device_prep_dma_cyclic = rcar_dmac_prep_dma_cyclic;
Of course, it will be removed in the next version.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2014-08-06 15:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-31 0:34 [PATCH 5/6] dmaengine: rcar-dmac: Add Renesas R-Car Gen2 DMA Controller (DMAC) driver Simon Horman
2014-07-31 11:56 ` Vinod Koul
2014-08-04 16:30 ` Laurent Pinchart
2014-08-05 16:59 ` Vinod Koul
2014-08-05 23:35 ` Laurent Pinchart
2014-08-06 8:46 ` Geert Uytterhoeven
2014-08-06 12:47 ` Geert Uytterhoeven
2014-08-06 15:36 ` Laurent Pinchart [this message]
2014-08-19 16:06 ` Vinod Koul
2014-08-20 17:27 ` Laurent Pinchart
2014-08-28 7:22 ` Vinod Koul
2014-08-28 16:39 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6487467.jFjtprcHSy@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).