From: Jeff Layton <jlayton@kernel.org>
To: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
lsf-pc@lists.linux-foundation.org
Cc: linux-fsdevel@vger.kernel.org,
Christian Brauner <brauner@kernel.org>,
Christoph Hellwig <hch@lst.de>, Jan Kara <jack@suse.cz>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-m68k <linux-m68k@vger.kernel.org>,
linux-sh <linux-sh@vger.kernel.org>
Subject: Re: [LSF/MM/BPF TOPIC] Should we make inode->i_ino a u64?
Date: Fri, 17 Apr 2026 07:28:30 -0700 [thread overview]
Message-ID: <69128c3b114098797f20094ff8d86524189491f5.camel@kernel.org> (raw)
In-Reply-To: <54b7990fc554ef446b094bf37b785d91ea68b075.camel@physik.fu-berlin.de>
On Fri, 2026-04-17 at 10:34 +0200, John Paul Adrian Glaubitz wrote:
> > The reality is more complicated...
> >
> > struct inode is (almost) always embedded in another structure that
> > contains the fs-specific fields for it. Many of those (nfs, xfs, etc.)
> > have had to carry a separate 64 bit field to hold the "real" inode
> > number since we couldn't count on i_ino being big enough on 32-bit
> > arches.
> >
> > Those fields can now go away, and once they do, that will represent a
> > 4-byte _reduction_ in size of the inode on those filesystems. So there
> > are potential upsides here for 32-bit arches as well.
>
> Then why not mention this? Why communicate a message that seems to imply
> that performance will be degraded on 32-bit targets?
>
>
Others have already addressed your other points, so I won't bother, but
for this one...
At the time I was writing the patches, I was thinking mostly about the
linux-fsdevel@ audience. Any change to the kernel _always_ comes with
tradeoffs and I've found it's best to be straightforward about the
potential downsides of any change.
I probably should have made more clear that the potential downsides in
this case were almost certainly not measurable. Mea culpa.
--
Jeff Layton <jlayton@kernel.org>
next prev parent reply other threads:[~2026-04-17 14:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <08f8444c7237566ffb4ba8c9eb0ab4b4a5f14440.camel@kernel.org>
2026-04-15 9:11 ` [LSF/MM/BPF TOPIC] Should we make inode->i_ino a u64? John Paul Adrian Glaubitz
2026-04-15 13:44 ` Jeff Layton
2026-04-17 8:34 ` John Paul Adrian Glaubitz
2026-04-17 14:28 ` Jeff Layton [this message]
2026-04-15 14:47 ` Theodore Tso
2026-04-24 6:38 ` Kolbjørn Barmen
2026-04-24 7:32 ` Geert Uytterhoeven
2026-04-24 11:57 ` Theodore Tso
2026-04-15 14:59 ` Darrick J. Wong
2026-04-16 5:33 ` Christoph Hellwig
2026-04-17 9:48 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69128c3b114098797f20094ff8d86524189491f5.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=brauner@kernel.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=lsf-pc@lists.linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox