From: <Conor.Dooley@microchip.com>
To: <mail@conchuod.ie>, <monstr@monstr.eu>,
<paul.walmsley@sifive.com>, <palmer@dabbelt.com>,
<aou@eecs.berkeley.edu>, <hca@linux.ibm.com>, <gor@linux.ibm.com>,
<agordeev@linux.ibm.com>, <borntraeger@linux.ibm.com>,
<svens@linux.ibm.com>, <ysato@users.sourceforge.jp>,
<dalias@libc.org>, <davem@davemloft.net>, <tglx@linutronix.de>,
<mingo@redhat.com>, <bp@alien8.de>, <dave.hansen@linux.intel.com>,
<x86@kernel.org>, <hpa@zytor.com>, <arnd@arndb.de>
Cc: <geert@linux-m68k.org>, <keescook@chromium.org>,
<peterz@infradead.org>, <linux-kernel@vger.kernel.org>,
<linux-riscv@lists.infradead.org>, <linux-s390@vger.kernel.org>,
<linux-sh@vger.kernel.org>, <sparclinux@vger.kernel.org>,
<linux-arch@vger.kernel.org>
Subject: Re: [PATCH 1/6] asm-generic: add a cpuinfo_ops definition in shared code
Date: Sun, 21 Aug 2022 11:44:10 +0000 [thread overview]
Message-ID: <6ec9945a-d749-2bed-edb5-837a3e3c95ed@microchip.com> (raw)
In-Reply-To: <20220821113512.2056409-2-mail@conchuod.ie>
On 21/08/2022 12:35, Conor Dooley wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> asm-generic: add a cpuinfo_ops definition in shared code
Meh, bad subject..
Obviously not going to respin right away for that.
>
> From: Conor Dooley <conor.dooley@microchip.com>
>
> On RISC-V sparse complains that:
> arch/riscv/kernel/cpu.c:204:29: warning: symbol 'cpuinfo_op' was not declared. Should it be static?
>
> Sure, it could be dumped into asm/processor.h like other archs have
> done, but putting it in an asm-generic header seems to be a saner
> strategy.
>
> Fixes: 76d2a0493a17 ("RISC-V: Init and Halt Code")
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> arch/riscv/include/asm/processor.h | 1 +
> include/asm-generic/processor.h | 7 +++++++
> 2 files changed, 8 insertions(+)
> create mode 100644 include/asm-generic/processor.h
>
> diff --git a/arch/riscv/include/asm/processor.h b/arch/riscv/include/asm/processor.h
> index 19eedd4af4cd..dd2c9a382192 100644
> --- a/arch/riscv/include/asm/processor.h
> +++ b/arch/riscv/include/asm/processor.h
> @@ -9,6 +9,7 @@
> #include <linux/const.h>
>
> #include <vdso/processor.h>
> +#include <asm-generic/processor.h>
>
> #include <asm/ptrace.h>
>
> diff --git a/include/asm-generic/processor.h b/include/asm-generic/processor.h
> new file mode 100644
> index 000000000000..2ec9af562e9b
> --- /dev/null
> +++ b/include/asm-generic/processor.h
> @@ -0,0 +1,7 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +#ifndef __ASM_PROCESSOR_H
> +#define __ASM_PROCESSOR_H
> +
> +extern const struct seq_operations cpuinfo_op;
> +
> +#endif /* __ASM_PROCESSOR_H */
> --
> 2.37.1
>
next prev parent reply other threads:[~2022-08-21 11:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-21 11:35 [PATCH 0/6] Add an asm-generic cpuinfo_op declaration Conor Dooley
2022-08-21 11:35 ` [PATCH 1/6] asm-generic: add a cpuinfo_ops definition in shared code Conor Dooley
2022-08-21 11:44 ` Conor.Dooley [this message]
2022-08-21 11:35 ` [PATCH 2/6] microblaze: use the asm-generic version of cpuinfo_op Conor Dooley
2022-08-21 11:35 ` [PATCH 3/6] s390: " Conor Dooley
2022-08-21 11:35 ` [PATCH 4/6] sh: " Conor Dooley
2022-08-21 11:35 ` [PATCH 5/6] sparc: " Conor Dooley
2022-08-26 14:47 ` Sam Ravnborg
2022-08-26 15:37 ` Conor.Dooley
2022-08-26 17:41 ` Sam Ravnborg
2022-08-21 11:35 ` [PATCH 6/6] x86: " Conor Dooley
2022-08-22 9:36 ` [PATCH 0/6] Add an asm-generic cpuinfo_op declaration Geert Uytterhoeven
2022-08-22 10:05 ` Conor.Dooley
2022-08-22 10:45 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ec9945a-d749-2bed-edb5-837a3e3c95ed@microchip.com \
--to=conor.dooley@microchip.com \
--cc=agordeev@linux.ibm.com \
--cc=aou@eecs.berkeley.edu \
--cc=arnd@arndb.de \
--cc=borntraeger@linux.ibm.com \
--cc=bp@alien8.de \
--cc=dalias@libc.org \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=mail@conchuod.ie \
--cc=mingo@redhat.com \
--cc=monstr@monstr.eu \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=peterz@infradead.org \
--cc=sparclinux@vger.kernel.org \
--cc=svens@linux.ibm.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).