* Re: HOTPLUG_CPU is not defined
2008-09-30 16:30 HOTPLUG_CPU is not defined Francis Moreau
@ 2008-09-30 18:24 ` Paul Mundt
2008-09-30 18:51 ` Francis Moreau
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Paul Mundt @ 2008-09-30 18:24 UTC (permalink / raw)
To: linux-sh
On Tue, Sep 30, 2008 at 06:30:00PM +0200, Francis Moreau wrote:
> Any reasons why this macro is not defined for SH ?
>
Yes, it's not implemented.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: HOTPLUG_CPU is not defined
2008-09-30 16:30 HOTPLUG_CPU is not defined Francis Moreau
2008-09-30 18:24 ` Paul Mundt
@ 2008-09-30 18:51 ` Francis Moreau
2008-09-30 18:55 ` Paul Mundt
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Francis Moreau @ 2008-09-30 18:51 UTC (permalink / raw)
To: linux-sh
On Tue, Sep 30, 2008 at 8:24 PM, Paul Mundt <lethal@linux-sh.org> wrote:
> On Tue, Sep 30, 2008 at 06:30:00PM +0200, Francis Moreau wrote:
>> Any reasons why this macro is not defined for SH ?
>>
> Yes, it's not implemented.
>
Well, it doesn't really matter and it avoids some warnings emitted
by Kconfig because of this in kernel/power/Kconfig:
config PM_SLEEP_SMP
bool
....
select HOTPLUG_CPU
default y
thanks
--
Francis
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: HOTPLUG_CPU is not defined
2008-09-30 16:30 HOTPLUG_CPU is not defined Francis Moreau
2008-09-30 18:24 ` Paul Mundt
2008-09-30 18:51 ` Francis Moreau
@ 2008-09-30 18:55 ` Paul Mundt
2008-10-01 8:27 ` Francis Moreau
2008-10-01 10:45 ` Paul Mundt
4 siblings, 0 replies; 6+ messages in thread
From: Paul Mundt @ 2008-09-30 18:55 UTC (permalink / raw)
To: linux-sh
On Tue, Sep 30, 2008 at 08:51:08PM +0200, Francis Moreau wrote:
> On Tue, Sep 30, 2008 at 8:24 PM, Paul Mundt <lethal@linux-sh.org> wrote:
> > On Tue, Sep 30, 2008 at 06:30:00PM +0200, Francis Moreau wrote:
> >> Any reasons why this macro is not defined for SH ?
> >>
> > Yes, it's not implemented.
> >
>
> Well, it doesn't really matter and it avoids some warnings emitted
> by Kconfig because of this in kernel/power/Kconfig:
>
>
> config PM_SLEEP_SMP
> bool
> ....
> select HOTPLUG_CPU
> default y
>
We don't provide symbols for stuff we don't support. The fact people
screw up select usage is nothing new, which is part of the reason it
should generally be avoided.
Your options are either to fix the PM_SLEEP_SMP Kconfig behaviour, or
ignore the warning. We're not going to paper around it in the
architecture side at least.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: HOTPLUG_CPU is not defined
2008-09-30 16:30 HOTPLUG_CPU is not defined Francis Moreau
` (2 preceding siblings ...)
2008-09-30 18:55 ` Paul Mundt
@ 2008-10-01 8:27 ` Francis Moreau
2008-10-01 10:45 ` Paul Mundt
4 siblings, 0 replies; 6+ messages in thread
From: Francis Moreau @ 2008-10-01 8:27 UTC (permalink / raw)
To: linux-sh
On Tue, Sep 30, 2008 at 8:55 PM, Paul Mundt <lethal@linux-sh.org> wrote:
> On Tue, Sep 30, 2008 at 08:51:08PM +0200, Francis Moreau wrote:
>> On Tue, Sep 30, 2008 at 8:24 PM, Paul Mundt <lethal@linux-sh.org> wrote:
>> > On Tue, Sep 30, 2008 at 06:30:00PM +0200, Francis Moreau wrote:
>> >> Any reasons why this macro is not defined for SH ?
>> >>
>> > Yes, it's not implemented.
>> >
>>
>> Well, it doesn't really matter and it avoids some warnings emitted
>> by Kconfig because of this in kernel/power/Kconfig:
>>
>>
>> config PM_SLEEP_SMP
>> bool
>> ....
>> select HOTPLUG_CPU
>> default y
>>
> We don't provide symbols for stuff we don't support. The fact people
> screw up select usage is nothing new, which is part of the reason it
> should generally be avoided.
>
Still we could define it with a default value to 'n', in that case the symbol
is not provided for the code and kconfig doesn't generate the warning
anymore.
thanks
--
Francis
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: HOTPLUG_CPU is not defined
2008-09-30 16:30 HOTPLUG_CPU is not defined Francis Moreau
` (3 preceding siblings ...)
2008-10-01 8:27 ` Francis Moreau
@ 2008-10-01 10:45 ` Paul Mundt
4 siblings, 0 replies; 6+ messages in thread
From: Paul Mundt @ 2008-10-01 10:45 UTC (permalink / raw)
To: linux-sh
On Wed, Oct 01, 2008 at 10:27:14AM +0200, Francis Moreau wrote:
> On Tue, Sep 30, 2008 at 8:55 PM, Paul Mundt <lethal@linux-sh.org> wrote:
> > On Tue, Sep 30, 2008 at 08:51:08PM +0200, Francis Moreau wrote:
> >> On Tue, Sep 30, 2008 at 8:24 PM, Paul Mundt <lethal@linux-sh.org> wrote:
> >> > On Tue, Sep 30, 2008 at 06:30:00PM +0200, Francis Moreau wrote:
> >> >> Any reasons why this macro is not defined for SH ?
> >> >>
> >> > Yes, it's not implemented.
> >> >
> >>
> >> Well, it doesn't really matter and it avoids some warnings emitted
> >> by Kconfig because of this in kernel/power/Kconfig:
> >>
> >>
> >> config PM_SLEEP_SMP
> >> bool
> >> ....
> >> select HOTPLUG_CPU
> >> default y
> >>
> > We don't provide symbols for stuff we don't support. The fact people
> > screw up select usage is nothing new, which is part of the reason it
> > should generally be avoided.
> >
>
> Still we could define it with a default value to 'n', in that case the symbol
> is not provided for the code and kconfig doesn't generate the warning
> anymore.
>
Except that 'select' negates that entirely if the symbol is defined,
regardless of whether we give it a value or not. Presently we don't
define any of the symbols that PM_SLEEP_SMP depends on:
config PM_SLEEP_SMP
bool
depends on SMP
depends on ARCH_SUSPEND_POSSIBLE || ARCH_HIBERNATION_POSSIBLE
depends on PM_SLEEP
select HOTPLUG_CPU
If any of those dependencies change, the select will automatically enable
HOTPLUG_CPU for us if we provide the symbol, regardless of whether it's
just a bool or default n or whatever else.
If you want this warning to go away, either have the select dropped or get the
Kconfig people to fix the dependency tracking. Again, we will not be papering
around this in the architecture code. We do not make a habit of "fixing" things
to make warnings go away when the warnings themselves are bogus. While the
kernel janitors are fond of this sort of mindless work, it is actively harmful
and doesn't help anything in the least.
^ permalink raw reply [flat|nested] 6+ messages in thread