Re: [PATCH 1/2] iommu: Add driver for Renesas VMSA-compatible IPMMU

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Ben,

On Friday 28 February 2014 15:37:00 Ben Dooks wrote:
> only minor issue so far:
> > diff --git a/include/linux/platform_data/ipmmu-vmsa.h
> > b/include/linux/platform_data/ipmmu-vmsa.h new file mode 100644
> > index 0000000..8be27e0
> > --- /dev/null
> > +++ b/include/linux/platform_data/ipmmu-vmsa.h
> > @@ -0,0 +1,24 @@
> > +/*
> > + * IPMMU VMSA Platform Data
> > + *
> > + * Copyright (C) 2014 Reneses Electronics Coporation
> 
> typo

That should be easy to fix :-)

> > + * This program is free software; you can redistribute it and/or modify
> > + * it under the terms of the GNU General Public License as published by
> > + * the Free Software Foundation; version 2 of the License.
> > + */
> > +
> > +#ifndef __IPMMU_VMSA_H__
> > +#define __IPMMU_VMSA_H__
> > +
> > +struct ipmmu_vmsa_master {
> > +	const char *name;
> > +	unsigned int utlb;
> > +};
> > +
> > +struct ipmmu_vmsa_platform_data {
> > +	const struct ipmmu_vmsa_master *masters;
> > +	unsigned int num_masters;
> > +};
> > +
> > +#endif /* __IPMMU_VMSA_H__ */
> 
> Also, what about the of-bindings?

That's planned and will come in a second step. I was first trying to get the 
IPMMU working.

-- 
Regards,

Laurent Pinchart