From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH v2 03/10] ARM: shmobile: sh73a0: common clock framework board support
Date: Tue, 09 Sep 2014 21:55:25 +0000 [thread overview]
Message-ID: <7505137.5ghCJd5oxl@avalon> (raw)
In-Reply-To: <1409649186-1046-4-git-send-email-ulrich.hecht+renesas@gmail.com>
Hi Simon and Ulrich,
On Thursday 04 September 2014 16:33:41 Simon Horman wrote:
> On Thu, Sep 04, 2014 at 09:19:59AM +0200, Geert Uytterhoeven wrote:
> > On Thu, Sep 4, 2014 at 9:10 AM, Simon Horman <horms@verge.net.au> wrote:
> > >> +#ifdef CONFIG_COMMON_CLK
> > >> +static const struct clk_name clk_names[] __initconst = {
> > >> + { "cmt1", NULL, "sh_cmt.10" },
> > >> + { "scifa0", NULL, "sh-sci.0" },
> > >> + { "scifa1", NULL, "sh-sci.1" },
> > >> + { "scifa2", NULL, "sh-sci.2" },
> > >> + { "scifa3", NULL, "sh-sci.3" },
> > >> + { "scifa4", NULL, "sh-sci.4" },
> > >> + { "scifa5", NULL, "sh-sci.5" },
> > >> + { "scifa6", NULL, "sh-sci.6" },
> > >> + { "scifa7", NULL, "sh-sci.7" },
> > >> + { "scifb", NULL, "sh-sci.8" },
> > >> + { "sdhi0", NULL, "ee100000.sd" },
> > >> + { "sdhi1", NULL, "ee120000.sd" },
> > >> + { "sdhi2", NULL, "ee140000.sd" },
> > >> + { "mmcif0", NULL, "e6bd0000.mmc" },
> > >> + { "iic0", NULL, "e6820000.i2c" },
> > >> + { "iic3", NULL, "e6826000.i2c" },
> > >> +};
> > >> +#endif
> > >> +
> > >>
> > >> static void __init kzm_init(void)
> > >> {
> > >>
> > >> +#ifdef CONFIG_COMMON_CLK
> > >> + shmobile_clk_workaround(clk_names, ARRAY_SIZE(clk_names), false);
> > >> +#endif
> > >>
> > >> sh73a0_add_standard_devices_dt();
> > >
> > > I believe that the above work-around no longer needed since
> > > 3c90c55dcde745bed81f6447f24ba96bda43d984 ("drivers: sh: compile
> > > drivers/sh/pm_runtime.c if ARCH_SHMOBILE_MULTI").
> >
> > That commit applies to the "shmobile_clk_workaround(..., true)" calls.
> >
> > The "shmobile_clk_workaround(..., false)" calls are still needed for
> > devices not instantiated from DT.
> >
> > >From the device names' formats, that applies to the cmt1 and scif*
> > >devices?
> >
> > However, I thought scif* was instantiated from DT?
> > And cmt1 is being moved?
>
> My reading of this series is that they will be initialised by
> DT by subsequent patches. Perhaps the patches could be re-ordered
> and the workaround omitted?
I would like that better too. The workaround should at least be removed after
adding device clocks in DT.
> Am I confused (again)?
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2014-09-09 21:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-02 9:12 [PATCH v2 03/10] ARM: shmobile: sh73a0: common clock framework board support Ulrich Hecht
2014-09-04 7:10 ` Simon Horman
2014-09-04 7:19 ` Geert Uytterhoeven
2014-09-04 7:33 ` Simon Horman
2014-09-09 21:55 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7505137.5ghCJd5oxl@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox