From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Date: Fri, 08 Nov 2013 13:50:09 +0000 Subject: Re: [PATCH 05/10] ARM: shmobile: lager-reference: Switch to multiplaform Message-Id: <7956055.J2tgr2Cg5d@avalon> List-Id: References: <1383059082-26315-6-git-send-email-laurent.pinchart+renesas@ideasonboard.com> In-Reply-To: <1383059082-26315-6-git-send-email-laurent.pinchart+renesas@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-sh@vger.kernel.org Hi Simon, On Friday 08 November 2013 15:25:47 Simon Horman wrote: > On Wed, Nov 06, 2013 at 06:15:33PM +0900, Magnus Damm wrote: > > Hi Simon, Laurent, > > > > On Wed, Nov 6, 2013 at 5:23 PM, Simon Horman wrote: > > > On Tue, Oct 29, 2013 at 04:04:37PM +0100, Laurent Pinchart wrote: > > >> Move the Lager reference board to multiplaform ARM architecture. As > > >> multiplatform requires usage of the common clock framework, switch from > > >> legacy clocks to CCF by replacing the legacy clock framework > > >> initialization code in the machine init handler with a common clock > > >> framework initialization call in the time init handler. > > >> > > >> Signed-off-by: Laurent Pinchart > > >> > > >> --- > > >> > > >> arch/arm/mach-shmobile/Kconfig | 7 +++++++ > > >> arch/arm/mach-shmobile/Makefile | 1 + > > >> arch/arm/mach-shmobile/board-lager-reference.c | 13 +++++++++---- > > >> 3 files changed, 17 insertions(+), 4 deletions(-) > > >> > > >> diff --git a/arch/arm/mach-shmobile/Kconfig > > >> b/arch/arm/mach-shmobile/Kconfig index 4bb548f..b39f6b6 100644 > > >> --- a/arch/arm/mach-shmobile/Kconfig > > >> +++ b/arch/arm/mach-shmobile/Kconfig > > >> @@ -20,6 +20,9 @@ comment "SH-Mobile System Type" > > >> > > >> config ARCH_EMEV2 > > >> > > >> bool "Emma Mobile EV2" > > >> > > >> +config ARCH_R8A7790 > > >> + bool "R-Car H2 (R8A77900)" > > >> + > > > > > > I realise that up until now there has only been one entry, > > > but in keeping with the non-SHMOBILE_MULTI entries I think it > > > would be good to have the SHMOBILE_MULTI entries sorted in alphabetical > > > order. With this in mind could you move ARCH_R8A7790 to > > > above ARCH_EMEV2? > > > > Actually, since we have multiple boards that all want to go into > > SHMOBILE_MULTI, I wonder if we can merge the initial code early > > somehow? > > > > Ideally I'd like to keep the DT reference board build for both CCF and > > legacy clocks for a while. So we want the same code to be built with > > SHMOBILE and SHMOBILE_MULTI. When we have got the CCF DT bindings > > merged then we can get rid of the legacy DT reference build option. > > > > See the following commit for an example: > > > > cbc60e7c04f3c1390144d4a881f0a7b98b49da98 > > cbc60e7c04f3c139 ("ARM: shmobile: Add EMEV2 and KZM9D to > ARCH_SHMOBILE_MULTI") seems like a reasonable approach to me. On r8a7790 board code needs to explicitly call a function exported by the drivers/clk/shmobile/clk-r8a7790.c driver. I thus need to merge that driver before modifying board code, which can be done unconditionally at that point. -- Regards, Laurent Pinchart