public inbox for linux-sh@vger.kernel.org
 help / color / mirror / Atom feed
From: "Carl Shaw" <shaw.carl@gmail.com>
To: linux-sh@vger.kernel.org
Subject: Re: Question about framebuffer and kernel module
Date: Thu, 11 Sep 2008 14:29:56 +0000	[thread overview]
Message-ID: <7e9e4a0c0809110729m5ed92510rad105c358e22ebfe@mail.gmail.com> (raw)
In-Reply-To: <600adaf50809110713y7c21b8b9l53b7b8798d1741e9@mail.gmail.com>

Hi Tiago,

This should be redirected to the ST support Bugzilla at
https://bugzilla.stlinux.com/

It is not a generic SH kernel problem.

Regards,
Carl


On Thu, Sep 11, 2008 at 3:13 PM, Tiago Maluta <tiago.maluta@gmail.com> wrote:
> Hi,
>
> I'm work with frame buffer devices on ST reference boards using
> stmfb-3.0_stm23_0009 with kernel linux-2.6.17.14_stm22_0038.
>
> After system boot I try to load stmcore-display-stx7100.ko
>
> #modprobe stmcore-display-stx7100
> stmcore_display_stx7100: Unknown symbol request_firmware
>
> Looking at /devkit/sources/stmfb/stmfb/Linux/stm/coredisplay/devfbOS.c
> I've commented the following lines and works.
>
> --- a/devfbOS.c 2008-09-11 10:14:09.000000000 -0300
> +++ b/devfbOS.c 2008-09-11 10:15:05.000000000 -0300
> @@ -722,7 +722,8 @@
>     /* get linux firmware */
>     printk ("requesting frm: '%s', %p/%p\n",
>             name, &firmware_device, &lnx_firmware);
> -    error = request_firmware ((const struct firmware **)
> (&lnx_firmware), name, &firmware_device);
> +    //error = request_firmware ((const struct firmware **)
> (&lnx_firmware), name, &firmware_device);
> +    error=1;
>     if (unlikely (error))
>     {
>       kfree (fw);
> @@ -748,7 +749,7 @@
>     list_add_tail (&fw->fw_list, &fwd->fw_cache);
>
>     /* release linux firmware */
> -    release_firmware (lnx_firmware);
> +    /* release_firmware (lnx_firmware); */
>   }
>
> I know this fix work   because they didn't try to release firmware on module...
> But I didn't know why it really works and the implications doing what I do?
>
>
> Best regards,
> Tiago Maluta
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

      parent reply	other threads:[~2008-09-11 14:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-11 14:13 Question about framebuffer and kernel module Tiago Maluta
2008-09-11 14:29 ` Carmelo AMOROSO
2008-09-11 14:29 ` Carl Shaw [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7e9e4a0c0809110729m5ed92510rad105c358e22ebfe@mail.gmail.com \
    --to=shaw.carl@gmail.com \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox