From: Randy Dunlap <rdunlap@infradead.org>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
Thomas Zimmermann <tzimmermann@suse.de>
Cc: deller@gmx.de, javierm@redhat.com, linux-sh@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
amd-gfx@lists.freedesktop.org, linux-input@vger.kernel.org,
linux-media@vger.kernel.org, linux-fbdev@vger.kernel.org,
linux-staging@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-geode@lists.infradead.org,
linux-nvidia@lists.surfsouth.com, linux-hyperv@vger.kernel.org,
linux-omap@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
kvm@vger.kernel.org, Miguel Ojeda <ojeda@kernel.org>
Subject: Re: [PATCH v2 18/18] fbdev: Document that framebuffer_alloc() returns zero'ed data
Date: Thu, 13 Jul 2023 09:02:39 -0700 [thread overview]
Message-ID: <801dbd65-ee7f-526d-6cd8-27cb0291c4ba@infradead.org> (raw)
In-Reply-To: <CANiq72mbLmMKph8aiz4apNF9n3MtVO-nhM9rEWYApZbSVAO9Qw@mail.gmail.com>
On 7/13/23 06:21, Miguel Ojeda wrote:
> On Thu, Jul 13, 2023 at 3:03 PM Thomas Zimmermann <tzimmermann@suse.de> wrote:
>>
>> Most fbdev drivers depend on framebuffer_alloc() to initialize the
>> allocated memory to 0. Document this guarantee.
>>
>> Suggested-by: Miguel Ojeda <ojeda@kernel.org>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>> Cc: Helge Deller <deller@gmx.de>
>
> Thanks for sending this! Maybe this would be best earlier in the
> series, so that later patches make more sense (since they use the
> guarantee), but it is not a big deal.
>
>> + * aligned to sizeof(long). Both, the instance of struct fb_info and
>> + * the driver private data, are cleared to zero.
>
> I think both commas may be best omitted (but I am not a native speaker).
Yes, it would be better to omit them.
> Reviewed-by: Miguel Ojeda <ojeda@kernel.org>
>
> Cheers,
> Miguel
--
~Randy
prev parent reply other threads:[~2023-07-13 16:02 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 12:58 [PATCH v2 00/18] fbdev: Remove FBINFO_DEFAULT and FBINFO_FLAG_DEFAULT flags Thomas Zimmermann
2023-07-13 12:58 ` [PATCH v2 01/18] drm: Remove flag FBINFO_DEFAULT from fbdev emulation Thomas Zimmermann
2023-07-13 12:58 ` [PATCH v2 02/18] fbdev: Remove flag FBINFO_DEFAULT from fbdev drivers Thomas Zimmermann
2023-07-13 12:58 ` [PATCH v2 03/18] " Thomas Zimmermann
2023-07-13 12:58 ` [PATCH v2 04/18] " Thomas Zimmermann
2023-07-13 12:58 ` [PATCH v2 05/18] " Thomas Zimmermann
2023-07-13 12:58 ` [PATCH v2 06/18] fbdev/fsl-diu-fb: Remove flag FBINFO_DEFAULT Thomas Zimmermann
2023-07-13 12:58 ` [PATCH v2 07/18] vfio-mdev: Remove flag FBINFO_DEFAULT from fbdev sample driver Thomas Zimmermann
2023-07-13 12:58 ` [PATCH v2 08/18] sh: Assign FB_MODE_IS_UNKNOWN to struct fb_videomode.flag Thomas Zimmermann
2023-07-13 13:53 ` John Paul Adrian Glaubitz
2023-07-13 13:56 ` John Paul Adrian Glaubitz
2023-07-13 12:58 ` [PATCH v2 09/18] auxdisplay: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers Thomas Zimmermann
2023-07-13 12:58 ` [PATCH v2 10/18] hid/picolcd: Remove flag FBINFO_FLAG_DEFAULT from fbdev driver Thomas Zimmermann
2023-07-13 12:58 ` [PATCH v2 11/18] media: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers Thomas Zimmermann
2023-07-13 12:58 ` [PATCH v2 12/18] staging: " Thomas Zimmermann
2023-07-13 12:58 ` [PATCH v2 13/18] fbdev: " Thomas Zimmermann
2023-07-13 12:58 ` [PATCH v2 14/18] " Thomas Zimmermann
2023-07-13 12:58 ` [PATCH v2 15/18] fbdev/atafb: Remove flag FBINFO_FLAG_DEFAULT Thomas Zimmermann
2023-07-13 12:58 ` [PATCH v2 16/18] fbdev/pxafb: " Thomas Zimmermann
2023-07-13 12:58 ` [PATCH v2 17/18] fbdev: Remove FBINFO_DEFAULT and FBINFO_FLAG_DEFAULT Thomas Zimmermann
2023-07-13 12:58 ` [PATCH v2 18/18] fbdev: Document that framebuffer_alloc() returns zero'ed data Thomas Zimmermann
2023-07-13 13:21 ` Miguel Ojeda
2023-07-13 16:02 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=801dbd65-ee7f-526d-6cd8-27cb0291c4ba@infradead.org \
--to=rdunlap@infradead.org \
--cc=amd-gfx@lists.freedesktop.org \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=javierm@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-geode@lists.infradead.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-nvidia@lists.surfsouth.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ojeda@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).