From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83CA9C04A6A for ; Thu, 13 Jul 2023 16:02:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235079AbjGMQCs (ORCPT ); Thu, 13 Jul 2023 12:02:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233618AbjGMQCq (ORCPT ); Thu, 13 Jul 2023 12:02:46 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F44226B2; Thu, 13 Jul 2023 09:02:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=FGfECluQ+8FqgloN5y7njhMRYgbNQmkghpgv24LmuxM=; b=0XY4/FQJa9khQp7bFpbGplPtrB 5SpA/Xwz1+y5xMC8TkQ/RIwD1YWvtpubNsS1DOufMRk8U8ZOw4QBT/2OcdaSsugIN7fvQtpI7FoTv cytb12hmpQ++kNkMjOGEjV3X0J/VuBhB9uSnfg9JjtfUZNml3TMudThtLyoBgiurIyPLTXfpsW1zN ZtXFfJPqxyrJBHJb3985aNxuQmUFSYt3wjhQoX2i+JeMJunamtLIY8iXJ5jgN3F/OMabSTImubkKK MN74NscjU6mryhy24nJ4dBieOuA4YvnVsMsArDKWNb60xY8A4s7oL4npScU177xtucZj0Dk4Lyl65 o8/EadpQ==; Received: from [2601:1c2:980:9ec0::2764] by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qJym9-003r1C-08; Thu, 13 Jul 2023 16:02:41 +0000 Message-ID: <801dbd65-ee7f-526d-6cd8-27cb0291c4ba@infradead.org> Date: Thu, 13 Jul 2023 09:02:39 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v2 18/18] fbdev: Document that framebuffer_alloc() returns zero'ed data Content-Language: en-US To: Miguel Ojeda , Thomas Zimmermann Cc: deller@gmx.de, javierm@redhat.com, linux-sh@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-geode@lists.infradead.org, linux-nvidia@lists.surfsouth.com, linux-hyperv@vger.kernel.org, linux-omap@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, Miguel Ojeda References: <20230713130338.31086-1-tzimmermann@suse.de> <20230713130338.31086-19-tzimmermann@suse.de> From: Randy Dunlap In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org On 7/13/23 06:21, Miguel Ojeda wrote: > On Thu, Jul 13, 2023 at 3:03 PM Thomas Zimmermann wrote: >> >> Most fbdev drivers depend on framebuffer_alloc() to initialize the >> allocated memory to 0. Document this guarantee. >> >> Suggested-by: Miguel Ojeda >> Signed-off-by: Thomas Zimmermann >> Cc: Helge Deller > > Thanks for sending this! Maybe this would be best earlier in the > series, so that later patches make more sense (since they use the > guarantee), but it is not a big deal. > >> + * aligned to sizeof(long). Both, the instance of struct fb_info and >> + * the driver private data, are cleared to zero. > > I think both commas may be best omitted (but I am not a native speaker). Yes, it would be better to omit them. > Reviewed-by: Miguel Ojeda > > Cheers, > Miguel -- ~Randy