From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 0/5] ARM: shmobile: Enable drivers/sh/pm_runtime.c on multi-platform
Date: Thu, 20 Mar 2014 11:59:30 +0000 [thread overview]
Message-ID: <8114222.hr4ELyZWaz@avalon> (raw)
In-Reply-To: <1395256010-12222-1-git-send-email-geert@linux-m68k.org>
Hi Geert,
On Thursday 20 March 2014 09:56:17 Ben Dooks wrote:
> On 19/03/14 20:06, Geert Uytterhoeven wrote:
> > This patchset enables the PM runtime code in drivers/sh/pm_runtime.c when
> > running a multi-platform ARM kernel including support for shmobile.
> > Before this code was only enabled for legacy shmobile kernels, leading to
> > disabled clocks in multiplatform kernels, depending on implicit reset
> > state or on the bootloader.
> >
> > [1/5] drivers: sh: pm_runtime does not need idle callback
> > [2/5] sh: intc: Restrict INTC_USERIMASK to SH4A
>
> I thought there was already a of capable intc driver in the
> irq drivers directory?
I think Ben's point is that drivers/sh/intc might be completely unneeded for
ARM.
> > [3/5] drivers: sh: compile drivers/sh/pm_runtime.c if
> > ARCH_SHMOBILE_MULTI
> > [4/5] ARM: shmobile: Call sh_pm_runtime_init() from platform code on
> > all
> >
> > SoCs
> >
> > [5/5] drivers: sh: Remove automatic sh_pm_runtime_init() if
> >
> > ARCH_SHMOBILE_LEGACY
> >
> > Patches 1 and 3 were authored by Ben Dooks, with some changes made by me
> > (for patch 3). Patch 4 was based on a patch by Ben for r8a7790.
> >
> > After this it should be safe to revert the various commits to "Work around
> > core clock issues". Note that this is just a port of the existing
> > sh(mobile)-specifc PM runtime code from legacy to multi-platform, so
> > expect more work to fix the core issues.
> >
> > This was tested on Koelsch, both legacy and multi-platform.
> >
> > Many thanks to Ben Dooks, Laurent Pinchart, and Magnus Damm for the
> > valuable input, investigations, and discussions.
>
> Thanks, I will probably not get around to testing this until next
> week as I am not in the office until Monday now. I think there is
> one more thing we need to do, which is to do a device suspend and
> resume like the current davinci implementation.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2014-03-20 11:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-19 19:06 [PATCH 0/5] ARM: shmobile: Enable drivers/sh/pm_runtime.c on multi-platform Geert Uytterhoeven
2014-03-20 1:48 ` Laurent Pinchart
2014-03-20 8:56 ` Ben Dooks
2014-03-20 9:14 ` Geert Uytterhoeven
2014-03-20 9:35 ` Ben Dooks
2014-03-20 11:59 ` Laurent Pinchart [this message]
2014-03-20 12:13 ` Geert Uytterhoeven
2014-03-20 12:18 ` Geert Uytterhoeven
2014-03-20 12:19 ` Laurent Pinchart
2014-03-20 12:24 ` Ben Dooks
2014-04-14 5:10 ` Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8114222.hr4ELyZWaz@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).