From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56C42EE14A9 for ; Thu, 7 Sep 2023 03:35:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231432AbjIGDfX convert rfc822-to-8bit (ORCPT ); Wed, 6 Sep 2023 23:35:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229782AbjIGDfW (ORCPT ); Wed, 6 Sep 2023 23:35:22 -0400 Received: from hsmtpd-def.xspmail.jp (hsmtpd-def.xspmail.jp [202.238.198.240]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B8561700 for ; Wed, 6 Sep 2023 20:35:18 -0700 (PDT) X-Country-Code: JP Received: from sakura.ysato.name (ik1-413-38519.vs.sakura.ne.jp [153.127.30.23]) by hsmtpd-out-2.asahinet.cluster.xspmail.jp (Halon) with ESMTPA id 419151f4-36d5-487e-91f9-38dae4d1e072; Thu, 07 Sep 2023 12:35:16 +0900 (JST) Received: from SIOS1075.ysato.ml (al128006.dynamic.ppp.asahi-net.or.jp [111.234.128.6]) by sakura.ysato.name (Postfix) with ESMTPSA id 1AFD91C0323; Thu, 7 Sep 2023 12:35:14 +0900 (JST) Date: Thu, 07 Sep 2023 12:35:13 +0900 Message-ID: <871qfaveoe.wl-ysato@users.sourceforge.jp> From: Yoshinori Sato To: Geert Uytterhoeven Cc: linux-sh@vger.kernel.org, glaubitz@physik.fu-berlin.de Subject: Re: [RESEND RFC PATCH 01/12] sh: Add OF target boards. In-Reply-To: References: <95d8b86480c60012252b37b9b13e5f709a2ec177.1693444193.git.ysato@users.sourceforge.jp> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org On Fri, 01 Sep 2023 23:26:10 +0900, Geert Uytterhoeven wrote: > > Hi Sato-san, > > On Thu, Aug 31, 2023 at 5:19 AM Yoshinori Sato > wrote: > > --- a/arch/sh/Kconfig > > +++ b/arch/sh/Kconfig > > > @@ -702,7 +707,7 @@ config BUILTIN_DTB_SOURCE > > config ZERO_PAGE_OFFSET > > hex > > default "0x00010000" if PAGE_SIZE_64KB || SH_RTS7751R2D || \ > > - SH_7751_SOLUTION_ENGINE > > + SH_7751_SOLUTION_ENGINE || SH_RTS7751R2D_OF > > This is the only user of SH_RTS7751R2D_OF. Can we get rid of it? > > > default "0x00004000" if PAGE_SIZE_16KB || SH_SH03 > > default "0x00002000" if PAGE_SIZE_8KB > > default "0x00001000" > > > --- a/arch/sh/boards/Kconfig > > +++ b/arch/sh/boards/Kconfig > > @@ -161,6 +166,17 @@ config SH_RTS7751R2D > > Select RTS7751R2D if configuring for a Renesas Technology > > Sales SH-Graphics board. > > > > +config SH_RTS7751R2D_OF > > + bool "RTS7751R2D (DeviceTree)" > > + depends on CPU_SUBTYPE_SH7751R > > + select HAVE_PCI > > + select IO_TRAPPED if MMU > > + select SH_DEVICE_TREE > > + select COMMON_CLK > > + help > > + Select RTS7751R2D if configuring for a Renesas Technology > > + Sales SH-Graphics board. (Use DeviceTree) > > + > > config SH_RSK > > bool "Renesas Starter Kit" > > depends on CPU_SUBTYPE_SH7201 || CPU_SUBTYPE_SH7203 || \ > > @@ -300,8 +316,20 @@ config SH_LANDISK > > bool "LANDISK" > > depends on CPU_SUBTYPE_SH7751R > > select HAVE_PCI > > + select SYS_SUPPORTS_PCI > > + help > > + I-O DATA DEVICE, INC. "LANDISK Series" support. > > + > > +config SH_LANDISK_OF > > + bool "LANDISK (DeviceTree)" > > + depends on CPU_SUBTYPE_SH7751R > > + select HAVE_PCI > > + select SYS_SUPPORTS_PCI > > + select SH_DEVICE_TREE > > + select COMMON_CLK > > help > > I-O DATA DEVICE, INC. "LANDISK Series" support. > > + Use Device Tree. > > > > config SH_TITAN > > bool "TITAN" > > Apart from the above, there are no users of the "_OF" symbols. > Do we need them? OK. I added "OpenFirmware supported target boards" in Board Support. Once OF support is available, the old ones will be fine as departed. > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds -- Yosinori Sato