From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Ball Date: Thu, 06 Jun 2013 11:43:28 +0000 Subject: Re: [PATCH v2] MMC: tmio: fix unbalanced power-on calls with clock-gating enabled Message-Id: <871u8f8nxb.fsf@octavius.laptop.org> List-Id: References: In-Reply-To: (Guennadi Liakhovetski's message of "Tue, 23 Apr 2013 09:29:44 +0200 (CEST)") MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Guennadi Liakhovetski Cc: linux-mmc@vger.kernel.org, linux-sh@vger.kernel.org, Laurent Pinchart Hi, On Tue, Apr 23 2013, Guennadi Liakhovetski wrote: > With MMC clock gating enabled the MMC core currently calls MMC host driver's > .set_ios() method with .power_mode = MMC_POWER_ON and the clock value set > either to 0 or to the target rate. The tmio MMC driver then wrongly > translates the latter calls to card slot power-on requests, even when the > slot already was on. This patch fixes the driver to avoid needlessly > incrementing power-supplying regulator's use count. > > Signed-off-by: Guennadi Liakhovetski This doesn't apply to mmc-next -- please could you rebase/resend? - Chris. -- Chris Ball One Laptop Per Child