* [PATCH] ALSA: sh: SND_AICA should depend on SH_DMA_API
@ 2025-05-13 7:31 Geert Uytterhoeven
2025-05-13 8:59 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2025-05-13 7:31 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai, Necip Fazil Yildiran, Rich Felker
Cc: linux-sound, linux-sh, Geert Uytterhoeven, kernel test robot
If CONFIG_SH_DMA_API=n:
WARNING: unmet direct dependencies detected for G2_DMA
Depends on [n]: SH_DREAMCAST [=y] && SH_DMA_API [=n]
Selected by [y]:
- SND_AICA [=y] && SOUND [=y] && SND [=y] && SND_SUPERH [=y] && SH_DREAMCAST [=y]
SND_AICA selects G2_DMA. As the latter depends on SH_DMA_API, the
former should depend on SH_DMA_API, too.
Fixes: f477a538c14d07f8 ("sh: dma: fix kconfig dependency for G2_DMA")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202505131320.PzgTtl9H-lkp@intel.com/
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
sound/sh/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/sh/Kconfig b/sound/sh/Kconfig
index b75fbb3236a7b945..f5fa09d740b4c954 100644
--- a/sound/sh/Kconfig
+++ b/sound/sh/Kconfig
@@ -14,7 +14,7 @@ if SND_SUPERH
config SND_AICA
tristate "Dreamcast Yamaha AICA sound"
- depends on SH_DREAMCAST
+ depends on SH_DREAMCAST && SH_DMA_API
select SND_PCM
select G2_DMA
help
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ALSA: sh: SND_AICA should depend on SH_DMA_API
2025-05-13 7:31 [PATCH] ALSA: sh: SND_AICA should depend on SH_DMA_API Geert Uytterhoeven
@ 2025-05-13 8:59 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2025-05-13 8:59 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Jaroslav Kysela, Takashi Iwai, Necip Fazil Yildiran, Rich Felker,
linux-sound, linux-sh, kernel test robot
On Tue, 13 May 2025 09:31:04 +0200,
Geert Uytterhoeven wrote:
>
> If CONFIG_SH_DMA_API=n:
>
> WARNING: unmet direct dependencies detected for G2_DMA
> Depends on [n]: SH_DREAMCAST [=y] && SH_DMA_API [=n]
> Selected by [y]:
> - SND_AICA [=y] && SOUND [=y] && SND [=y] && SND_SUPERH [=y] && SH_DREAMCAST [=y]
>
> SND_AICA selects G2_DMA. As the latter depends on SH_DMA_API, the
> former should depend on SH_DMA_API, too.
>
> Fixes: f477a538c14d07f8 ("sh: dma: fix kconfig dependency for G2_DMA")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202505131320.PzgTtl9H-lkp@intel.com/
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Applied now. Thanks.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-05-13 9:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-13 7:31 [PATCH] ALSA: sh: SND_AICA should depend on SH_DMA_API Geert Uytterhoeven
2025-05-13 8:59 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).