From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED9ECC001B0 for ; Wed, 19 Jul 2023 14:25:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231665AbjGSOZS (ORCPT ); Wed, 19 Jul 2023 10:25:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55590 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231511AbjGSOZH (ORCPT ); Wed, 19 Jul 2023 10:25:07 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0665119B1 for ; Wed, 19 Jul 2023 07:24:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689776638; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AYL0WxfELPHjwx6ZiDqavEiQQIijrcopNRfhrvLV03A=; b=Fy8i5nOuJc9vT64qGI1h402ACgpl6AB64fP+pSezsKXU7oX0ASaTIrY6cxryrL9cV8OvNU v0sIZeURGjZ3itQ6NPF0MFxRumgHZwjZfMTfec/c/ZD6nxw8e6l3CXc8VJBtqU8rK9ljTf QgQvU5p0Ucau8pjJq5qE+94Kp1SQ6E8= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-342-Avr0WtS5NVav49mE5-Lisg-1; Wed, 19 Jul 2023 10:23:56 -0400 X-MC-Unique: Avr0WtS5NVav49mE5-Lisg-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-3fc08035926so3789705e9.0 for ; Wed, 19 Jul 2023 07:23:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689776635; x=1690381435; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AYL0WxfELPHjwx6ZiDqavEiQQIijrcopNRfhrvLV03A=; b=In8Uzr0uyk7ev+IByAm/GlMmllEATPJyPG1N7D7uSpmdtjqCKzRT2fuOLfujkVmYEO YJEHJGNw5AuP5bkNjRbusyiOaXlogoT1rpflUEF7sp1+pzCyzvbdawLEeJIYKHT8UOll tJQhgMZaqBMmDmfB0vRMpeIN7jClTZYuS4cPHDxRORz3lyEPs5D8GV4zHJFHAhu7Z4UB wg0C4YlgWQuYXsa4TobJFbf0ZxmB+jyw0mrH16A6lPSmWP2wkt1qJJ2/9UkSpqE0kmTW 2ZxbGjskiGcdSQAJha3eYeZNWYWImS8KraiQlJVLHcFB0W/kRsu9H+od9byR/IEmxo1H FL/w== X-Gm-Message-State: ABy/qLZ8ppvU0SaJF59IbJyHFWsDeuaHMsU7uTEbxuvsah/jPOfSmbT1 EG4jeJeZ4XfnI6H+GR/K1jT4J+unTdq//FH8QQ0O3pjW/r6ZAA9uDtP4WSCo0n9ECNvCyIFtGYK 7u+nuWLDK0L9vvE/QRQ8= X-Received: by 2002:adf:f406:0:b0:317:15f5:a1cc with SMTP id g6-20020adff406000000b0031715f5a1ccmr41784wro.22.1689776635696; Wed, 19 Jul 2023 07:23:55 -0700 (PDT) X-Google-Smtp-Source: APBJJlHAuWaDn4wkaE25f0gFYugdobiggD0h46Z8p4U2s3LOHj24u3Bx+1zUs1XU1djJ3aSjiu0SQg== X-Received: by 2002:adf:f406:0:b0:317:15f5:a1cc with SMTP id g6-20020adff406000000b0031715f5a1ccmr41757wro.22.1689776635405; Wed, 19 Jul 2023 07:23:55 -0700 (PDT) Received: from localhost (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id q19-20020a056000137300b003143d80d11dsm5429196wrz.112.2023.07.19.07.23.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Jul 2023 07:23:54 -0700 (PDT) From: Javier Martinez Canillas To: Arnd Bergmann , linux-fbdev@vger.kernel.org, Thomas Zimmermann , Helge Deller Cc: Arnd Bergmann , "David S. Miller" , "K. Y. Srinivasan" , Ard Biesheuvel , Borislav Petkov , Brian Cain , Catalin Marinas , Christophe Leroy , Daniel Vetter , Dave Hansen , David Airlie , Deepak Rawat , Dexuan Cui , Dinh Nguyen , Greg Kroah-Hartman , Guo Ren , Haiyang Zhang , Huacai Chen , Ingo Molnar , John Paul Adrian Glaubitz , Khalid Aziz , Linus Walleij , Matt Turner , Max Filippov , Michael Ellerman , Nicholas Piggin , Palmer Dabbelt , Russell King , Thomas Bogendoerfer , Thomas Gleixner , WANG Xuerui , Wei Liu , Will Deacon , x86@kernel.org, linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-efi@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-hyperv@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v2 7/9] vga16fb: drop powerpc support In-Reply-To: <20230719123944.3438363-8-arnd@kernel.org> References: <20230719123944.3438363-1-arnd@kernel.org> <20230719123944.3438363-8-arnd@kernel.org> Date: Wed, 19 Jul 2023 16:23:53 +0200 Message-ID: <87a5vshtdy.fsf@minerva.mail-host-address-is-not-set> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org Arnd Bergmann writes: > From: Arnd Bergmann > > I noticed that commit 0db5b61e0dc07 ("fbdev/vga16fb: Create > EGA/VGA devices in sysfb code") broke vga16fb on non-x86 platforms, > because the sysfb code never creates a vga-framebuffer device when > screen_info.orig_video_isVGA is set to '1' instead of VIDEO_TYPE_VGAC. > > However, it turns out that the only architecture that has allowed > building vga16fb in the past 20 years is powerpc, and this only worked > on two 32-bit platforms and never on 64-bit powerpc. The last machine > that actually used this was removed in linux-3.10, so this is all dead > code and can be removed. > > The big-endian support in vga16fb.c could also be removed, but I'd just > leave this in place. > > Fixes: 933ee7119fb14 ("powerpc: remove PReP platform") > Signed-off-by: Arnd Bergmann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat