Re: [RESEND RFC PATCH 01/12] sh: Add OF target boards.

[Yoshinori Sato <ysato@users.sourceforge.jp>]

On Fri, 01 Sep 2023 23:26:10 +0900,
Geert Uytterhoeven wrote:
> 
> Hi Sato-san,
> 
> On Thu, Aug 31, 2023 at 5:19 AM Yoshinori Sato
> <ysato@users.sourceforge.jp> wrote:
> > --- a/arch/sh/Kconfig
> > +++ b/arch/sh/Kconfig
> 
> > @@ -702,7 +707,7 @@ config BUILTIN_DTB_SOURCE
> >  config ZERO_PAGE_OFFSET
> >         hex
> >         default "0x00010000" if PAGE_SIZE_64KB || SH_RTS7751R2D || \
> > -                               SH_7751_SOLUTION_ENGINE
> > +                               SH_7751_SOLUTION_ENGINE || SH_RTS7751R2D_OF
> 
> This is the only user of SH_RTS7751R2D_OF. Can we get rid of it?
> 
> >         default "0x00004000" if PAGE_SIZE_16KB || SH_SH03
> >         default "0x00002000" if PAGE_SIZE_8KB
> >         default "0x00001000"
> 
> > --- a/arch/sh/boards/Kconfig
> > +++ b/arch/sh/boards/Kconfig
> > @@ -161,6 +166,17 @@ config SH_RTS7751R2D
> >           Select RTS7751R2D if configuring for a Renesas Technology
> >           Sales SH-Graphics board.
> >
> > +config SH_RTS7751R2D_OF
> > +       bool "RTS7751R2D (DeviceTree)"
> > +       depends on CPU_SUBTYPE_SH7751R
> > +       select HAVE_PCI
> > +       select IO_TRAPPED if MMU
> > +       select SH_DEVICE_TREE
> > +       select COMMON_CLK
> > +       help
> > +         Select RTS7751R2D if configuring for a Renesas Technology
> > +         Sales SH-Graphics board. (Use DeviceTree)
> > +
> >  config SH_RSK
> >         bool "Renesas Starter Kit"
> >         depends on CPU_SUBTYPE_SH7201 || CPU_SUBTYPE_SH7203 || \
> > @@ -300,8 +316,20 @@ config SH_LANDISK
> >         bool "LANDISK"
> >         depends on CPU_SUBTYPE_SH7751R
> >         select HAVE_PCI
> > +       select SYS_SUPPORTS_PCI
> > +       help
> > +         I-O DATA DEVICE, INC. "LANDISK Series" support.
> > +
> > +config SH_LANDISK_OF
> > +       bool "LANDISK (DeviceTree)"
> > +       depends on CPU_SUBTYPE_SH7751R
> > +       select HAVE_PCI
> > +       select SYS_SUPPORTS_PCI
> > +       select SH_DEVICE_TREE
> > +       select COMMON_CLK
> >         help
> >           I-O DATA DEVICE, INC. "LANDISK Series" support.
> > +         Use Device Tree.
> >
> >  config SH_TITAN
> >         bool "TITAN"
> 
> Apart from the above, there are no users of the "<machine>_OF" symbols.
> Do we need them?

-- 
Yosinori Sato