SUPERH platform development
 help / color / mirror / Atom feed
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 7/8 v2] ASoC: fsi: remove slave_id settings for DMAEngine
Date: Thu, 22 Jan 2015 01:08:42 +0000	[thread overview]
Message-ID: <87bnlrmxim.wl%kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <87bnluaxtt.wl%kuninori.morimoto.gx@renesas.com>


Hi Arnd

> > Thank you for pointing it.
> > But, unfortunately, this FSI driver is not used from DT.
> > (It is supporting DT probe, but no one use it)
> > So, it is assuming that dst_addr/src_addr fields are come
> > from platform data.
> 
> I see. My patch would still be correct, right?
> 
> I think the way that Guennadi Liakhovetski started the conversion of
> shmobile dmaengine drivers, each slave driver either uses a custom
> filter function that relies on the platform data and will not work
> with DT, or it uses dma_request_slave_channel_compat() which will
> work on both, and then uses dmaengine_slave_config() to pass the
> extra settings. This driver is the one exception you have since it
> uses a combination of the two approaches.

I understand.
will fix in v3 patch

Best regards
---
Kuninori Morimoto

  parent reply	other threads:[~2015-01-22  1:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-20  4:18 [PATCH 7/8 v2] ASoC: fsi: remove slave_id settings for DMAEngine Kuninori Morimoto
2015-01-20 13:02 ` Arnd Bergmann
2015-01-21  1:33 ` Kuninori Morimoto
2015-01-21  9:15 ` Arnd Bergmann
2015-01-22  1:08 ` Kuninori Morimoto [this message]
2015-01-22  1:24 ` Kuninori Morimoto
2015-01-22  9:43 ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bnlrmxim.wl%kuninori.morimoto.gx@renesas.com \
    --to=kuninori.morimoto.gx@renesas.com \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox