From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Simon <horms@verge.net.au>, Chris Ball <cjb@laptop.org>,
Magnus <magnus.damm@gmail.com>,
Linux-SH <linux-sh@vger.kernel.org>,
Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>,
linux-mmc@vger.kernel.org
Subject: Re: [PATCH 1/2 v2] ARM: shmobile: lager: add gpio/fixed regulator for SDHI
Date: Tue, 19 Nov 2013 05:14:15 +0000 [thread overview]
Message-ID: <87bo1hdlcs.wl%kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <7870553.GWO3OgcztQ@avalon>
Hi Laurent
> > #include <linux/platform_data/rcar-du.h>
> > #include <linux/platform_device.h>
> > #include <linux/phy.h>
> > +#include <linux/regulator/driver.h>
>
> I might be mistaken, but is this header really needed ?
Unfortunately, the compile will error without it.
regulator_xxx / REGULATOR_XXX need it
> > +static struct fixed_voltage_config vcc_sdhi##idx##_info = { \
>
> You can make this structure const.
(snip)
> > +static struct gpio_regulator_config vccq_sdhi##idx##_info = { \
>
> You can make this structure const.
I see.
Thank you
Best regards
---
Kuninori Morimoto
next prev parent reply other threads:[~2013-11-19 5:14 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-14 10:16 [PATCH 0/16] SDHI support for r8a7790 Kuninori Morimoto
2013-11-14 10:18 ` [PATCH 0/16]: gpio-rcar fixup Kuninori Morimoto
2013-11-14 10:19 ` [PATCH 01/16] gpio: rcar: use postcore_init() Kuninori Morimoto
2013-11-14 13:42 ` Laurent Pinchart
2013-11-15 0:26 ` Kuninori Morimoto
2013-11-18 13:59 ` Laurent Pinchart
2013-11-19 9:57 ` Linus Walleij
2013-11-19 12:36 ` Laurent Pinchart
2013-11-21 2:02 ` Kuninori Morimoto
2013-11-14 10:21 ` [PATCH 0/16] mmc: bug fix patches Kuninori Morimoto
2013-11-14 10:23 ` [PATCH 03/17] mmc: tmio: Fix odd size access Kuninori Morimoto
2013-11-14 13:32 ` Laurent Pinchart
2013-11-14 10:24 ` [PATCH 04/17] mmc: tmio: Add error IRQ status clear Kuninori Morimoto
2013-11-14 13:34 ` Laurent Pinchart
2013-11-14 10:24 ` [PATCH 05/17] mmc: tmio: don't overwrite caps2 Kuninori Morimoto
2013-11-14 13:36 ` Laurent Pinchart
2013-11-14 10:26 ` [PATCH 0/16] ARM: shmobile: bug fix Kuninori Morimoto
2013-11-14 10:27 ` [PATCH 06/17] ARM: shmobile: marzen: remove SDHI0 WP pin setting from DTS Kuninori Morimoto
2013-11-14 13:38 ` Laurent Pinchart
2013-11-14 10:27 ` [PATCH 07/17] ARM: shmobile: marzen: remove SDHI0 WP pin setting Kuninori Morimoto
2013-11-14 13:38 ` Laurent Pinchart
2013-11-14 10:27 ` [PATCH 08/17] ARM: shmobile: sh73a0: fixup sdhi compatible name Kuninori Morimoto
2013-11-14 13:39 ` Laurent Pinchart
2013-11-14 10:29 ` [PATCH 0/16] mmc: SDHI: add new feature Kuninori Morimoto
2013-11-14 10:30 ` [PATCH 09/17] mmc: tmio: bus_shift become tmio_mmc_data member Kuninori Morimoto
2013-11-14 10:31 ` [PATCH 10/17] mmc: tmio: add new TMIO_MMC_HAVE_HIGH_REG flags Kuninori Morimoto
2013-11-14 10:31 ` [PATCH 11/17] mmc: SDHI: add SoC specific workaround via HW version Kuninori Morimoto
2013-11-14 14:03 ` Sergei Shtylyov
2013-11-15 0:16 ` Kuninori Morimoto
2013-11-14 10:31 ` [PATCH 12/17] mmc: SDHI: tidyup sh_mobile_sdhi_of_match position Kuninori Morimoto
2013-11-14 10:32 ` [PATCH 13/17] mmc: SDHI: updata sh_mobile_sdhi_of_data for r8a7778 Kuninori Morimoto
2013-11-14 10:32 ` [PATCH 14/17] mmc: SDHI: updata sh_mobile_sdhi_of_data for r8a7779 Kuninori Morimoto
2013-11-14 10:32 ` [PATCH 15/17] mmc: SDHI: updata sh_mobile_sdhi_of_data for r8a7790 Kuninori Morimoto
2013-11-14 10:34 ` [PATCH 0/16] ARM: shmobile: SDHI support " Kuninori Morimoto
2013-11-14 10:34 ` [PATCH 16/17] ARM: shmobile: lager: add SDHI0/2 support Kuninori Morimoto
2013-11-14 10:35 ` [PATCH 17/17] ARM: shmobile: lager: use gpio/fixed regulator for SDHI Kuninori Morimoto
2013-11-14 13:51 ` Laurent Pinchart
2013-11-15 0:42 ` Kuninori Morimoto
2013-11-14 13:46 ` [PATCH 0/16] ARM: shmobile: SDHI support for r8a7790 Laurent Pinchart
2013-11-15 0:43 ` Kuninori Morimoto
2013-11-15 1:53 ` Kuninori Morimoto
2013-11-15 1:55 ` [PATCH 1/2 v2] ARM: shmobile: lager: add gpio/fixed regulator for SDHI Kuninori Morimoto
2013-11-18 11:35 ` Laurent Pinchart
2013-11-19 5:14 ` Kuninori Morimoto [this message]
2013-11-19 12:45 ` Laurent Pinchart
2013-11-20 7:37 ` Kuninori Morimoto
2013-11-20 10:57 ` Laurent Pinchart
2013-11-21 1:53 ` Kuninori Morimoto
2013-12-05 6:11 ` Kuninori Morimoto
2013-12-05 6:59 ` Simon Horman
2014-02-12 6:25 ` [PATCH 1/2 v2] ARM: shmobile: lager: add SDHI0/2 support Kuninori Morimoto
2013-11-15 1:56 ` [PATCH 2/2 " Kuninori Morimoto
2013-11-18 7:21 ` [PATCH 0/16] ARM: shmobile: SDHI support for r8a7790 Simon Horman
2013-11-18 7:42 ` Kuninori Morimoto
2013-11-21 3:53 ` Simon Horman
2013-11-21 5:20 ` Kuninori Morimoto
2013-11-21 8:48 ` Simon Horman
2013-11-20 0:43 ` [PATCH 0/16] " Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bo1hdlcs.wl%kuninori.morimoto.gx@renesas.com \
--to=kuninori.morimoto.gx@renesas.com \
--cc=cjb@laptop.org \
--cc=horms@verge.net.au \
--cc=kuninori.morimoto.gx@gmail.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).