From: Yoshinori Sato <ysato@users.sourceforge.jp>
To: Rich Felker <dalias@libc.org>
Cc: linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND 03/12] sh: Disable board specific code in OF mode
Date: Tue, 10 May 2016 07:28:23 +0000 [thread overview]
Message-ID: <87eg9ape20.wl-ysato@users.sourceforge.jp> (raw)
In-Reply-To: <20160504024941.GN21636@brightrain.aerifal.cx>
Sorry too late reply.
On Wed, 04 May 2016 11:49:41 +0900,
Rich Felker wrote:
>
> On Sun, May 01, 2016 at 02:08:27PM +0900, Yoshinori Sato wrote:
> > Board specific code conflict on of-generic.
> >
> > Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
> > ---
> > arch/sh/Makefile | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
> >
> > diff --git a/arch/sh/Makefile b/arch/sh/Makefile
> > index bf5b3f5..8ff943b 100644
> > --- a/arch/sh/Makefile
> > +++ b/arch/sh/Makefile
> > @@ -130,6 +130,9 @@ head-y := arch/sh/kernel/head_$(BITS).o
> > core-y += arch/sh/kernel/ arch/sh/mm/ arch/sh/boards/
> > core-$(CONFIG_SH_FPU_EMU) += arch/sh/math-emu/
> >
> > +core-$(CONFIG_USE_BUILTIN_DTB) += arch/sh/boot/dts/
> > +
>
> It looks like you inadvertently mixed the builtin-dtb patch with this
> commit. Is yours based on the builtin-dtb patch I posted to the list
> or a different approach?
Oh sorry.
It changes same. I mistake origin version.
> > +ifneq ($(CONFIG_SH_DEVICE_TREE),y)
> > # Mach groups
> > machdir-$(CONFIG_SOLUTION_ENGINE) += mach-se
> > machdir-$(CONFIG_SH_HP6XX) += mach-hp6xx
> > @@ -150,6 +153,7 @@ machdir-$(CONFIG_SH_LANDISK) += mach-landisk
> > machdir-$(CONFIG_SH_LBOX_RE2) += mach-lboxre2
> > machdir-$(CONFIG_SH_CAYMAN) += mach-cayman
> > machdir-$(CONFIG_SH_RSK) += mach-rsk
> > +endif
>
> Is this actually necessary? I thought SH_DEVICE_TREE was mutually
> exclusive with board-specific configs at the Kconfig level. If not, it
> should probably be handled that way rather than with logic like this
> in the Makefile.
Hmm.
I think Kconfig level exclsive more better.
>
> > ifneq ($(machdir-y),)
> > core-y += $(addprefix arch/sh/boards/, \
> > @@ -222,6 +226,13 @@ archclean:
> > $(Q)$(MAKE) $(clean)=$(boot)
> > $(Q)$(MAKE) $(clean)=arch/sh/kernel/vsyscall
> >
> > +%.dtb %.dtb.S %.dtb.o: | scripts
> > + $(Q)$(MAKE) $(build)=arch/sh/boot/dts arch/sh/boot/dts/$@
> > +
> > +PHONY += dtbs
> > +dtbs: scripts
> > + $(Q)$(MAKE) $(build)=arch/sh/boot/dts
> > +
> > define archhelp
> > @echo ' zImage - Compressed kernel image'
> > @echo ' romImage - Compressed ROM image, if supported'
> > --
>
> More builtin-dtb stuff.
>
> Rich
--
Yoshinori Sato
<ysato@users.sourceforge.jp>
next prev parent reply other threads:[~2016-05-10 7:28 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-01 5:08 [PATCH RESEND 00/12] SH: landisk convert to devicetree Yoshinori Sato
2016-05-01 5:08 ` [PATCH RESEND 01/12] sh: Fix typo Yoshinori Sato
2016-05-01 5:08 ` [PATCH RESEND 02/12] sh: Config update for OF mode Yoshinori Sato
2016-05-01 5:08 ` [PATCH RESEND 03/12] sh: Disable board specific code in " Yoshinori Sato
2016-05-04 2:49 ` Rich Felker
2016-05-10 7:28 ` Yoshinori Sato [this message]
2016-05-01 5:08 ` [PATCH RESEND 04/12] sh: Drop CPU specific setup on " Yoshinori Sato
2016-05-01 5:08 ` [PATCH RESEND 05/12] sh: DeviceTree support update Yoshinori Sato
2016-05-04 3:10 ` Rich Felker
2016-05-04 6:41 ` Geert Uytterhoeven
2016-05-10 8:27 ` Yoshinori Sato
2016-05-10 8:25 ` Yoshinori Sato
2016-05-10 16:28 ` Rich Felker
2016-05-16 7:36 ` Yoshinori Sato
2016-05-01 5:08 ` [PATCH RESEND 06/12] clk: sh: SH7750/51 PLL and divider clock driver Yoshinori Sato
2016-05-01 20:48 ` Geert Uytterhoeven
2016-05-10 8:31 ` Yoshinori Sato
2016-05-01 5:08 ` [PATCH RESEND 07/12] pci: sh: SH7751 PCI host bridge driver Yoshinori Sato
2016-05-02 16:48 ` Bjorn Helgaas
2016-05-02 19:33 ` Bjorn Helgaas
2016-05-01 5:08 ` [PATCH RESEND 08/12] intc: sh: Renesas Super H INTC driver Yoshinori Sato
2016-05-01 5:08 ` [PATCH RESEND 09/12] sh: Add I/O DATA HDL-U support drivers Yoshinori Sato
2016-05-01 5:08 ` [PATCH RESEND 10/12] sh: I/O DATA HDL-U (aka landisk) support dts Yoshinori Sato
[not found] ` <1462079316-27771-11-git-send-email-ysato-Rn4VEauK+AKRv+LV9MX5uooqe+aC9MnS@public.gmane.org>
2016-05-04 3:27 ` Rich Felker
2016-05-10 7:43 ` Yoshinori Sato
2016-05-01 5:08 ` [PATCH RESEND 11/12] sh: I/O DATA HDL-U defconfig (DT mode) Yoshinori Sato
2016-05-01 5:08 ` [PATCH RESEND 12/12] of: Add sh support Yoshinori Sato
2016-05-02 12:35 ` Rob Herring
2016-05-10 7:46 ` Yoshinori Sato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eg9ape20.wl-ysato@users.sourceforge.jp \
--to=ysato@users.sourceforge.jp \
--cc=dalias@libc.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).