* [PATCH 0/3] rcar-hpbdma: fixup patches for double plane
@ 2013-10-17 10:50 Kuninori Morimoto
2013-10-17 12:39 ` Max Filippov
` (4 more replies)
0 siblings, 5 replies; 12+ messages in thread
From: Kuninori Morimoto @ 2013-10-17 10:50 UTC (permalink / raw)
To: linux-sh
Hi Simon, Max
These patches fixup R-Car HBPDMA driver
for double plane.
Max
Could you please review these patches ?
Especially last patch.
It checks DQSTS when double plane, but I'm not good at HPBDMA.
I tested these patches on my R-Car sound driver in local environment.
It doesn't work without these patches.
Kuninori Morimoto (3):
rcar-hpbdma: add max transfer size
rcar-hpbdma: initialise plane information when halted
rcar-hpbdma: fixup channel busy check for double plane
drivers/dma/sh/rcar-hpbdma.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
Best regards
---
Kuninori Morimoto
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 0/3] rcar-hpbdma: fixup patches for double plane 2013-10-17 10:50 [PATCH 0/3] rcar-hpbdma: fixup patches for double plane Kuninori Morimoto @ 2013-10-17 12:39 ` Max Filippov 2013-10-18 0:03 ` Kuninori Morimoto ` (3 subsequent siblings) 4 siblings, 0 replies; 12+ messages in thread From: Max Filippov @ 2013-10-17 12:39 UTC (permalink / raw) To: linux-sh Hi Kuninori, On Thu, Oct 17, 2013 at 2:50 PM, Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> wrote: > > Hi Simon, Max > > These patches fixup R-Car HBPDMA driver > for double plane. > > Max > > Could you please review these patches ? > Especially last patch. > It checks DQSTS when double plane, but I'm not good at HPBDMA. > > I tested these patches on my R-Car sound driver in local environment. > It doesn't work without these patches. > > Kuninori Morimoto (3): > rcar-hpbdma: add max transfer size > rcar-hpbdma: initialise plane information when halted > rcar-hpbdma: fixup channel busy check for double plane > > drivers/dma/sh/rcar-hpbdma.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) For the whole series: Reviewed-by: Max Filippov <max.filippov@cogentembedded.com> -- Thanks. -- Max ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 0/3] rcar-hpbdma: fixup patches for double plane 2013-10-17 10:50 [PATCH 0/3] rcar-hpbdma: fixup patches for double plane Kuninori Morimoto 2013-10-17 12:39 ` Max Filippov @ 2013-10-18 0:03 ` Kuninori Morimoto 2013-10-29 5:11 ` [off-list] " Simon Horman ` (2 subsequent siblings) 4 siblings, 0 replies; 12+ messages in thread From: Kuninori Morimoto @ 2013-10-18 0:03 UTC (permalink / raw) To: linux-sh Hi Simon These are v2 of R-Car HBPDMA fixup patches for double plane. Kuninori Morimoto (3): rcar-hpbdma: add max transfer size rcar-hpbdma: initialise plane information when halted rcar-hpbdma: fixup channel busy check for double plane drivers/dma/sh/rcar-hpbdma.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) Best regards --- Kuninori Morimoto ^ permalink raw reply [flat|nested] 12+ messages in thread
* [off-list] Re: [PATCH 0/3] rcar-hpbdma: fixup patches for double plane 2013-10-17 10:50 [PATCH 0/3] rcar-hpbdma: fixup patches for double plane Kuninori Morimoto 2013-10-17 12:39 ` Max Filippov 2013-10-18 0:03 ` Kuninori Morimoto @ 2013-10-29 5:11 ` Simon Horman 2013-10-29 5:12 ` Simon Horman 2013-10-29 6:51 ` Kuninori Morimoto 4 siblings, 0 replies; 12+ messages in thread From: Simon Horman @ 2013-10-29 5:11 UTC (permalink / raw) To: linux-sh Hi Morimoto-san, as these are dma patches shouldn't they go through (lazy) Vinod? If so, I'll Ack them ask you to repost them on the ML. If not, I guess I can set up a branch and see if I can get them accepted through the arm-soc tree or elsewhere. On Thu, Oct 17, 2013 at 05:03:54PM -0700, Kuninori Morimoto wrote: > > Hi Simon > > These are v2 of R-Car HBPDMA fixup patches > for double plane. > > Kuninori Morimoto (3): > rcar-hpbdma: add max transfer size > rcar-hpbdma: initialise plane information when halted > rcar-hpbdma: fixup channel busy check for double plane > > drivers/dma/sh/rcar-hpbdma.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > Best regards > --- > Kuninori Morimoto > -- > To unsubscribe from this list: send the line "unsubscribe linux-sh" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 0/3] rcar-hpbdma: fixup patches for double plane 2013-10-17 10:50 [PATCH 0/3] rcar-hpbdma: fixup patches for double plane Kuninori Morimoto ` (2 preceding siblings ...) 2013-10-29 5:11 ` [off-list] " Simon Horman @ 2013-10-29 5:12 ` Simon Horman 2013-10-29 6:51 ` Kuninori Morimoto 4 siblings, 0 replies; 12+ messages in thread From: Simon Horman @ 2013-10-29 5:12 UTC (permalink / raw) To: linux-sh Ooops, I responded on-list. On Tue, Oct 29, 2013 at 02:11:22PM +0900, Simon Horman wrote: > Hi Morimoto-san, > > as these are dma patches shouldn't they go through (lazy) Vinod? > If so, I'll Ack them ask you to repost them on the ML. > > If not, I guess I can set up a branch and see if I can get > them accepted through the arm-soc tree or elsewhere. > > On Thu, Oct 17, 2013 at 05:03:54PM -0700, Kuninori Morimoto wrote: > > > > Hi Simon > > > > These are v2 of R-Car HBPDMA fixup patches > > for double plane. > > > > Kuninori Morimoto (3): > > rcar-hpbdma: add max transfer size > > rcar-hpbdma: initialise plane information when halted > > rcar-hpbdma: fixup channel busy check for double plane > > > > drivers/dma/sh/rcar-hpbdma.c | 10 +++++++++- > > 1 file changed, 9 insertions(+), 1 deletion(-) > > > > Best regards > > --- > > Kuninori Morimoto > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-sh" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-sh" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 0/3] rcar-hpbdma: fixup patches for double plane 2013-10-17 10:50 [PATCH 0/3] rcar-hpbdma: fixup patches for double plane Kuninori Morimoto ` (3 preceding siblings ...) 2013-10-29 5:12 ` Simon Horman @ 2013-10-29 6:51 ` Kuninori Morimoto 2013-10-29 6:52 ` [PATCH 1/3] rcar-hpbdma: add max transfer size Kuninori Morimoto ` (5 more replies) 4 siblings, 6 replies; 12+ messages in thread From: Kuninori Morimoto @ 2013-10-29 6:51 UTC (permalink / raw) To: Koul, Vinod Cc: Simon, Max Filippov, Magnus, linux-sh, Kuninori Morimoto, linux-kernel Hi Vinod Cc: Simon, Max These patches fixup R-Car HBPDMA driver for double plane. I tested these patches on my R-Car sound driver in local environment. It doesn't work without these patches. Kuninori Morimoto (3): rcar-hpbdma: add max transfer size rcar-hpbdma: initialise plane information when halted rcar-hpbdma: fixup channel busy check for double plane drivers/dma/sh/rcar-hpbdma.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) Best regards --- Kuninori Morimoto ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 1/3] rcar-hpbdma: add max transfer size 2013-10-29 6:51 ` Kuninori Morimoto @ 2013-10-29 6:52 ` Kuninori Morimoto 2013-10-29 6:52 ` [PATCH 2/3] rcar-hpbdma: initialise plane information when halted Kuninori Morimoto ` (4 subsequent siblings) 5 siblings, 0 replies; 12+ messages in thread From: Kuninori Morimoto @ 2013-10-29 6:52 UTC (permalink / raw) To: Koul, Vinod Cc: Simon, Max Filippov, Magnus, linux-sh, Kuninori Morimoto, linux-kernel shdma_chan_probe() can set max transfer size, but it will be PAGE_SIZE with out this patch. Reviewed-by: Max Filippov <max.filippov@cogentembedded.com> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> --- drivers/dma/sh/rcar-hpbdma.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/dma/sh/rcar-hpbdma.c b/drivers/dma/sh/rcar-hpbdma.c index ebad845..496180a 100644 --- a/drivers/dma/sh/rcar-hpbdma.c +++ b/drivers/dma/sh/rcar-hpbdma.c @@ -510,6 +510,8 @@ static int hpb_dmae_chan_probe(struct hpb_dmae_device *hpbdev, int id) } schan = &new_hpb_chan->shdma_chan; + schan->max_xfer_len = HPB_DMA_TCR_MAX; + shdma_chan_probe(sdev, schan, id); if (pdev->id >= 0) -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 2/3] rcar-hpbdma: initialise plane information when halted 2013-10-29 6:51 ` Kuninori Morimoto 2013-10-29 6:52 ` [PATCH 1/3] rcar-hpbdma: add max transfer size Kuninori Morimoto @ 2013-10-29 6:52 ` Kuninori Morimoto 2013-10-29 6:52 ` [PATCH 3/3] rcar-hpbdma: fixup channel busy check for double plane Kuninori Morimoto ` (3 subsequent siblings) 5 siblings, 0 replies; 12+ messages in thread From: Kuninori Morimoto @ 2013-10-29 6:52 UTC (permalink / raw) To: Koul, Vinod Cc: Simon, Max Filippov, Magnus, linux-sh, Kuninori Morimoto, linux-kernel Plane information should be initialized when halted. It may restart from the wrong plane without this patch. Reviewed-by: Max Filippov <max.filippov@cogentembedded.com> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> --- drivers/dma/sh/rcar-hpbdma.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/dma/sh/rcar-hpbdma.c b/drivers/dma/sh/rcar-hpbdma.c index 496180a..19af32d 100644 --- a/drivers/dma/sh/rcar-hpbdma.c +++ b/drivers/dma/sh/rcar-hpbdma.c @@ -286,6 +286,9 @@ static void hpb_dmae_halt(struct shdma_chan *schan) ch_reg_write(chan, HPB_DMAE_DCMDR_DQEND, HPB_DMAE_DCMDR); ch_reg_write(chan, HPB_DMAE_DSTPR_DMSTP, HPB_DMAE_DSTPR); + + chan->plane_idx = 0; + chan->first_desc = true; } static const struct hpb_dmae_slave_config * -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 3/3] rcar-hpbdma: fixup channel busy check for double plane 2013-10-29 6:51 ` Kuninori Morimoto 2013-10-29 6:52 ` [PATCH 1/3] rcar-hpbdma: add max transfer size Kuninori Morimoto 2013-10-29 6:52 ` [PATCH 2/3] rcar-hpbdma: initialise plane information when halted Kuninori Morimoto @ 2013-10-29 6:52 ` Kuninori Morimoto 2013-10-29 7:08 ` [PATCH 0/3] rcar-hpbdma: fixup patches " Simon Horman ` (2 subsequent siblings) 5 siblings, 0 replies; 12+ messages in thread From: Kuninori Morimoto @ 2013-10-29 6:52 UTC (permalink / raw) To: Koul, Vinod Cc: Simon, Max Filippov, Magnus, linux-sh, Kuninori Morimoto, linux-kernel The device busy check method is different between single and double planes. It will always return "busy" without this patch if channel used as double plane. Reviewed-by: Max Filippov <max.filippov@cogentembedded.com> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> --- drivers/dma/sh/rcar-hpbdma.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/dma/sh/rcar-hpbdma.c b/drivers/dma/sh/rcar-hpbdma.c index 19af32d..3083d90 100644 --- a/drivers/dma/sh/rcar-hpbdma.c +++ b/drivers/dma/sh/rcar-hpbdma.c @@ -60,6 +60,7 @@ #define HPB_DMAE_DSTPR_DMSTP BIT(0) /* DMA status register (DSTSR) bits */ +#define HPB_DMAE_DSTSR_DQSTS BIT(2) #define HPB_DMAE_DSTSR_DMSTS BIT(0) /* DMA common registers */ @@ -388,7 +389,10 @@ static bool hpb_dmae_channel_busy(struct shdma_chan *schan) struct hpb_dmae_chan *chan = to_chan(schan); u32 dstsr = ch_reg_read(chan, HPB_DMAE_DSTSR); - return (dstsr & HPB_DMAE_DSTSR_DMSTS) = HPB_DMAE_DSTSR_DMSTS; + if (chan->xfer_mode = XFER_DOUBLE) + return dstsr & HPB_DMAE_DSTSR_DQSTS; + else + return dstsr & HPB_DMAE_DSTSR_DMSTS; } static int -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 0/3] rcar-hpbdma: fixup patches for double plane 2013-10-29 6:51 ` Kuninori Morimoto ` (2 preceding siblings ...) 2013-10-29 6:52 ` [PATCH 3/3] rcar-hpbdma: fixup channel busy check for double plane Kuninori Morimoto @ 2013-10-29 7:08 ` Simon Horman 2013-11-12 2:16 ` Kuninori Morimoto 2013-11-12 5:03 ` Vinod Koul 5 siblings, 0 replies; 12+ messages in thread From: Simon Horman @ 2013-10-29 7:08 UTC (permalink / raw) To: Kuninori Morimoto Cc: Koul, Vinod, Max Filippov, Magnus, linux-sh, Kuninori Morimoto, linux-kernel On Mon, Oct 28, 2013 at 11:51:28PM -0700, Kuninori Morimoto wrote: > > Hi Vinod > Cc: Simon, Max > > These patches fixup R-Car HBPDMA driver > for double plane. > > I tested these patches on my R-Car sound driver in local environment. > It doesn't work without these patches. > > Kuninori Morimoto (3): > rcar-hpbdma: add max transfer size > rcar-hpbdma: initialise plane information when halted > rcar-hpbdma: fixup channel busy check for double plane > > drivers/dma/sh/rcar-hpbdma.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) Thanks Morimoto-san, these all look good to me. Acked-by: Simon Horman <horms+renesas@verge.net.au> Vinod, could you consider applying these? ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 0/3] rcar-hpbdma: fixup patches for double plane 2013-10-29 6:51 ` Kuninori Morimoto ` (3 preceding siblings ...) 2013-10-29 7:08 ` [PATCH 0/3] rcar-hpbdma: fixup patches " Simon Horman @ 2013-11-12 2:16 ` Kuninori Morimoto 2013-11-12 5:03 ` Vinod Koul 5 siblings, 0 replies; 12+ messages in thread From: Kuninori Morimoto @ 2013-11-12 2:16 UTC (permalink / raw) To: Koul, Vinod Cc: Simon, Max Filippov, Magnus, linux-sh, Kuninori Morimoto, linux-kernel Hi Vinod Cc: Simon Please teach me current status of these patches > These patches fixup R-Car HBPDMA driver > for double plane. > > I tested these patches on my R-Car sound driver in local environment. > It doesn't work without these patches. > > Kuninori Morimoto (3): > rcar-hpbdma: add max transfer size > rcar-hpbdma: initialise plane information when halted > rcar-hpbdma: fixup channel busy check for double plane > > drivers/dma/sh/rcar-hpbdma.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > > Best regards > --- > Kuninori Morimoto Best regards --- Kuninori Morimoto ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 0/3] rcar-hpbdma: fixup patches for double plane 2013-10-29 6:51 ` Kuninori Morimoto ` (4 preceding siblings ...) 2013-11-12 2:16 ` Kuninori Morimoto @ 2013-11-12 5:03 ` Vinod Koul 5 siblings, 0 replies; 12+ messages in thread From: Vinod Koul @ 2013-11-12 5:03 UTC (permalink / raw) To: Kuninori Morimoto Cc: Simon, Max Filippov, Magnus, linux-sh, Kuninori Morimoto, linux-kernel On Mon, Oct 28, 2013 at 11:51:28PM -0700, Kuninori Morimoto wrote: > > Hi Vinod > Cc: Simon, Max > > These patches fixup R-Car HBPDMA driver > for double plane. > > I tested these patches on my R-Car sound driver in local environment. > It doesn't work without these patches. Applied, thanks -- ~Vinod > > Kuninori Morimoto (3): > rcar-hpbdma: add max transfer size > rcar-hpbdma: initialise plane information when halted > rcar-hpbdma: fixup channel busy check for double plane > > drivers/dma/sh/rcar-hpbdma.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > > Best regards > --- > Kuninori Morimoto -- ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2013-11-12 5:03 UTC | newest] Thread overview: 12+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-10-17 10:50 [PATCH 0/3] rcar-hpbdma: fixup patches for double plane Kuninori Morimoto 2013-10-17 12:39 ` Max Filippov 2013-10-18 0:03 ` Kuninori Morimoto 2013-10-29 5:11 ` [off-list] " Simon Horman 2013-10-29 5:12 ` Simon Horman 2013-10-29 6:51 ` Kuninori Morimoto 2013-10-29 6:52 ` [PATCH 1/3] rcar-hpbdma: add max transfer size Kuninori Morimoto 2013-10-29 6:52 ` [PATCH 2/3] rcar-hpbdma: initialise plane information when halted Kuninori Morimoto 2013-10-29 6:52 ` [PATCH 3/3] rcar-hpbdma: fixup channel busy check for double plane Kuninori Morimoto 2013-10-29 7:08 ` [PATCH 0/3] rcar-hpbdma: fixup patches " Simon Horman 2013-11-12 2:16 ` Kuninori Morimoto 2013-11-12 5:03 ` Vinod Koul
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).