From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3DA1C0032E for ; Thu, 26 Oct 2023 03:40:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229596AbjJZDkl convert rfc822-to-8bit (ORCPT ); Wed, 25 Oct 2023 23:40:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55244 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229554AbjJZDkk (ORCPT ); Wed, 25 Oct 2023 23:40:40 -0400 Received: from hsmtpd-def.xspmail.jp (hsmtpd-def.xspmail.jp [202.238.198.244]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C4250A3 for ; Wed, 25 Oct 2023 20:40:37 -0700 (PDT) X-Country-Code: JP Received: from sakura.ysato.name (ik1-413-38519.vs.sakura.ne.jp [153.127.30.23]) by hsmtpd-out-1.asahinet.cluster.xspmail.jp (Halon) with ESMTPA id 8782e932-9091-4d2e-ac64-e3c2e2c51c93; Thu, 26 Oct 2023 12:40:36 +0900 (JST) Received: from SIOS1075.ysato.ml (al128006.dynamic.ppp.asahi-net.or.jp [111.234.128.6]) by sakura.ysato.name (Postfix) with ESMTPSA id 0170D1C0037; Thu, 26 Oct 2023 12:40:33 +0900 (JST) Date: Thu, 26 Oct 2023 12:40:33 +0900 Message-ID: <87il6u6oge.wl-ysato@users.sourceforge.jp> From: Yoshinori Sato To: Geert Uytterhoeven Cc: linux-sh@vger.kernel.org, glaubitz@physik.fu-berlin.de Subject: Re: [RFC PATCH v3 06/35] arch/sh/boards/of-generic.c: some cleanup. In-Reply-To: References: <7b864c7ded52ace326c42b132708a6dc8ad9a606.1697199949.git.ysato@users.sourceforge.jp> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org On Thu, 19 Oct 2023 03:37:57 +0900, Geert Uytterhoeven wrote: > > Hi Sato-san, > > On Sat, Oct 14, 2023 at 4:54 PM Yoshinori Sato > wrote: > > Signed-off-by: Yoshinori Sato > > Thanks for your patch! > > > --- a/arch/sh/boards/of-generic.c > > +++ b/arch/sh/boards/of-generic.c > > @@ -140,25 +132,13 @@ static void __init sh_of_init_irq(void) > > irqchip_init(); > > } > > > > -static int __init sh_of_clk_init(void) > > -{ > > -#ifdef CONFIG_COMMON_CLK > > - /* Disabled pending move to COMMON_CLK framework. */ > > - pr_info("SH generic board support: scanning for clk providers\n"); > > - of_clk_init(NULL); > > -#endif > > - return 0; > > -} > > - > > Removing this breaks J2 for sure? I guess this should be merged with > "[RFC PATCH v3 07/35] arch/sh/kernel/time.c: support COMMON_CLK." > to avoid a bisection regression? > J2 timer (jcore-pit) used TIMER_OF_DECLARE This is the correct OF implementation, so it is initialized with timer_probe. I would like to eliminate as many SH-specific methods as possible. > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds -- Yosinori Sato