From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA24CCA0FE6 for ; Fri, 1 Sep 2023 13:34:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232143AbjIANeK convert rfc822-to-8bit (ORCPT ); Fri, 1 Sep 2023 09:34:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349772AbjIANeI (ORCPT ); Fri, 1 Sep 2023 09:34:08 -0400 Received: from hsmtpd-def.xspmail.jp (hsmtpd-def.xspmail.jp [202.238.198.245]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C165310E9 for ; Fri, 1 Sep 2023 06:34:03 -0700 (PDT) X-Country-Code: JP Received: from sakura.ysato.name (ik1-413-38519.vs.sakura.ne.jp [153.127.30.23]) by hsmtpd-out-0.asahinet.cluster.xspmail.jp (Halon) with ESMTPA id cbae3000-0f5d-4c6d-84c9-dfde4a462df0; Fri, 01 Sep 2023 22:34:01 +0900 (JST) Received: from SIOS1075.ysato.ml (ZM005235.ppp.dion.ne.jp [222.8.5.235]) by sakura.ysato.name (Postfix) with ESMTPSA id 8FC8A1C0323; Fri, 1 Sep 2023 22:33:59 +0900 (JST) Date: Fri, 01 Sep 2023 22:33:59 +0900 Message-ID: <87jztauiew.wl-ysato@users.sourceforge.jp> From: Yoshinori Sato To: Geert Uytterhoeven Cc: linux-sh@vger.kernel.org, glaubitz@physik.fu-berlin.de Subject: Re: [RESEND RFC PATCH 09/12] of: FDT vaddr support for SH. In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org On Fri, 01 Sep 2023 22:11:01 +0900, Geert Uytterhoeven wrote: > > Hi Sato-san, > > On Thu, Aug 31, 2023 at 5:18 AM Yoshinori Sato > wrote: > > sh using virt address in FDT. > > > > Signed-off-by: Yoshinori Sato > > Thanks for your patch! > > > --- a/drivers/of/fdt.c > > +++ b/drivers/of/fdt.c > > @@ -643,6 +643,9 @@ void __init early_init_fdt_scan_reserved_mem(void) > > fdt_get_mem_rsv(initial_boot_params, n, &base, &size); > > if (!size) > > break; > > +#ifdef CONFIG_SUPERH > > + base = virt_to_phys(base); > > +#endif > > I guess this is a no-go. > Why can't you use physical address, like all other platforms? I changed this before so I don't remember the exact details, but I feel like it was related to the built-in DTB. I think the correct way is to handle it in the SH dependent part. > > memblock_reserve(base, size); > > } > > > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds -- Yosinori Sato