From: Thomas Schwinge <thomas@codesourcery.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Paul Mundt <lethal@linux-sh.org>,
linux-sh@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH 3/7] serial: sh-sci: restore big-endian operation.
Date: Fri, 09 Mar 2012 20:23:46 +0000 [thread overview]
Message-ID: <87lin9mskt.fsf@schwinge.name> (raw)
In-Reply-To: <20120309171007.GA25965@kroah.com>
[-- Attachment #1: Type: text/plain, Size: 2160 bytes --]
Hi Greg!
First -- as you probably have guessed already -- I'm not (not yet?) :-)
too familiar with the Linux kernel patch submission process. I have
spent quite some time reading the included documentation, but apparently
missed some details... :-)
On Fri, 9 Mar 2012 09:10:07 -0800, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Fri, Mar 09, 2012 at 05:38:49PM +0100, Thomas Schwinge wrote:
> > As of 37b7a97884ba64bf7d403351ac2a9476ab4f1bba we have to use the
> > endianess-agnostic I/O accessor functions.
>
> Please always put a human readable description of what the git id is, so
> that we have a chance to understand what is going on.
Sorry. ``sh: machvec IO death.'' -- well, the essential part what I'm
fixing here is that before this commit readw (and friends, such as
ioread16) didn't do any endianess modification of the data, but directly
invoked __raw_readw, whereas after 37b7a978 they do such modification by
means of filtering through le16_to_cpu (in the readw/ioread16 case).
This is where things break for big endian (but not little endian, where
this is a no-op).
> Are these patches supposed to be going through the sh tree, or the
> serial tree to Linus?
I'm assuming that Paul Mundt will handle the whole lot in an SH tree.
Paul, by the way, if that's more convenient I can also publish my Git
tree.
> And watch your To: line, it seemed to be munged :(
Yes. By means of scripts/get_maintainer.pl (and some manual adjustments)
I created the Cc: lists that are part of my commits' log messages. Then,
I just had git send-email send that out, without explicitly specifying a
primary recipient (To: line). I assume I should have put Paul there?
On this patch, the linux-serial was Cced (as suggested by
scripts/get_maintainer.pl), as it touches a TTY/serial driver, and I
wanted to make sure to give you an opportunity to review that the patch
doesn't introduce any breakage on non-SH architectures, for example.
(Despite its indicative name, sh-sci also seems to be used on some ARM
boards.)
> confused,
Sorry; will hopefully improve. :-)
Grüße,
Thomas
[-- Attachment #2: Type: application/pgp-signature, Size: 489 bytes --]
next prev parent reply other threads:[~2012-03-09 20:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-09 16:38 [PATCH 1/7] SH: sh7785lcr board: restore big-endian operation Thomas Schwinge
2012-03-09 16:38 ` [PATCH 3/7] serial: sh-sci: " Thomas Schwinge
2012-03-09 17:10 ` Greg KH
2012-03-09 20:23 ` Thomas Schwinge [this message]
2012-03-09 16:38 ` [PATCH 5/7] USB: r8a66597-hcd: " Thomas Schwinge
2012-03-10 11:02 ` Sergei Shtylyov
2012-03-09 16:38 ` [PATCH 7/7] sm501: " Thomas Schwinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lin9mskt.fsf@schwinge.name \
--to=thomas@codesourcery.com \
--cc=gregkh@linuxfoundation.org \
--cc=lethal@linux-sh.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).