From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>
Date: Tue, 09 Sep 2014 06:07:06 +0000
Subject: Re: [PATCH 2/7 v3] mmc: use .multi_io_quirk on omap_hsmmc
Message-Id: <87oaup72ew.wl%kuninori.morimoto.gx@gmail.com>
List-Id: <linux-sh.vger.kernel.org>
References: <87r3zvzohj.wl%kuninori.morimoto.gx@gmail.com>
	<87bnqx78xr.wl%kuninori.morimoto.gx@gmail.com>
	<878um178vn.wl%kuninori.morimoto.gx@gmail.com>
	<CAPDyKFoj2_3APb1q_tJ8P8qmDb8RftOyx4+j_Sbb74kDSKEe7Q@mail.gmail.com>
	<87zje97izx.wl%kuninori.morimoto.gx@gmail.com>
	<CAPDyKFpns_+s3LQ-j=yE6vx-uzRtm5MwhxZVeB8r=fnBqJ8vBA@mail.gmail.com>
In-Reply-To: <CAPDyKFpns_+s3LQ-j=yE6vx-uzRtm5MwhxZVeB8r=fnBqJ8vBA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Chris Ball <cjb@laptop.org>, Simon <horms@verge.net.au>, Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>, Linux-SH <linux-sh@vger.kernel.org>, linux-mmc <linux-mmc@vger.kernel.org>


Hi Ulf

> > This means we need to copy this ops for each driver ?
> > Otherwise, it breaks behavior if many drivers were probed.
> 
> The are only one driver for omap_hsmmc, this is not tmio, which
> certainly is a different story.
> 
> What you need to do, is to make omap_hsmmc_ops non const - and assign
> the function pointer here. That should work.

I meant this case

omap_hsmmc@0 0xAAAAAA irq = xxxx (MULTI read workaround is needed)
omap_hsmmc@1 0xBBBBBB irq = yyyy (MULTI read workaround is not needed)

Maybe current omap doesn't have 2 hsmmc on 1 SoC (I don't know)
but, we don't know the future ?
Of course I can follow your style if this issue never happen

Best regards
---
Kuninori Morimoto