* [PATCH 2/2] ARM: shmobile: lager: add SDHI0/2 support on DTS
@ 2014-02-07 8:34 Kuninori Morimoto
2014-02-12 5:53 ` Magnus Damm
2014-02-12 6:13 ` Kuninori Morimoto
0 siblings, 2 replies; 3+ messages in thread
From: Kuninori Morimoto @ 2014-02-07 8:34 UTC (permalink / raw)
To: linux-sh
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
arch/arm/boot/dts/r8a7790-lager.dts | 84 +++++++++++++++++++++++++++++++++++
1 file changed, 84 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
index 1081c5e..972c75a 100644
--- a/arch/arm/boot/dts/r8a7790-lager.dts
+++ b/arch/arm/boot/dts/r8a7790-lager.dts
@@ -56,6 +56,54 @@
regulator-boot-on;
regulator-always-on;
};
+
+ vcc_sdhi0: regulator@1 {
+ compatible = "regulator-fixed";
+
+ regulator-name = "SDHI0 Vcc";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+
+ gpio = <&gpio5 24 GPIO_ACTIVE_HIGH>;
+ enable-active-high;
+ };
+
+ vccq_sdhi0: regulator@2 {
+ compatible = "regulator-gpio";
+
+ regulator-name = "SDHI0 VccQ";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <3300000>;
+
+ gpios = <&gpio5 29 GPIO_ACTIVE_HIGH>;
+ gpios-states = <1>;
+ states = <3300000 1
+ 1800000 0>;
+ };
+
+ vcc_sdhi2: regulator@3 {
+ compatible = "regulator-fixed";
+
+ regulator-name = "SDHI0 Vcc";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+
+ gpio = <&gpio5 25 GPIO_ACTIVE_HIGH>;
+ enable-active-high;
+ };
+
+ vccq_sdhi2: regulator@4 {
+ compatible = "regulator-gpio";
+
+ regulator-name = "SDHI0 VccQ";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <3300000>;
+
+ gpios = <&gpio5 30 GPIO_ACTIVE_HIGH>;
+ gpios-states = <1>;
+ states = <3300000 1
+ 1800000 0>;
+ };
};
&extal_clk {
@@ -76,6 +124,16 @@
renesas,function = "scif1";
};
+ sdhi0_pins: sd0 {
+ renesas,gpios = "sdhi0_data4", "sdhi0_ctrl", "sdhi0_cd";
+ renesas,function = "sdhi0";
+ };
+
+ sdhi2_pins: sd2 {
+ renesas,gpios = "sdhi2_data4", "sdhi2_ctrl", "sdhi2_cd";
+ renesas,function = "sdhi2";
+ };
+
mmc1_pins: mmc1 {
renesas,groups = "mmc1_data8", "mmc1_ctrl";
renesas,function = "mmc1";
@@ -95,3 +153,29 @@
&sata1 {
status = "okay";
};
+
+&sdhi0 {
+ pinctrl-0 = <&sdhi0_pins>;
+ pinctrl-names = "default";
+
+ vmmc-supply = <&vcc_sdhi0>;
+ vqmmc-supply = <&vccq_sdhi0>;
+ cap-sd-highspeed;
+ cap-sdio-irq;
+ cap-power-off-card;
+ toshiba,mmc-wrprotect-disable;
+ status = "okay";
+};
+
+&sdhi2 {
+ pinctrl-0 = <&sdhi2_pins>;
+ pinctrl-names = "default";
+
+ vmmc-supply = <&vcc_sdhi2>;
+ vqmmc-supply = <&vccq_sdhi2>;
+ cap-sd-highspeed;
+ cap-sdio-irq;
+ cap-power-off-card;
+ toshiba,mmc-wrprotect-disable;
+ status = "okay";
+};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] ARM: shmobile: lager: add SDHI0/2 support on DTS
2014-02-07 8:34 [PATCH 2/2] ARM: shmobile: lager: add SDHI0/2 support on DTS Kuninori Morimoto
@ 2014-02-12 5:53 ` Magnus Damm
2014-02-12 6:13 ` Kuninori Morimoto
1 sibling, 0 replies; 3+ messages in thread
From: Magnus Damm @ 2014-02-12 5:53 UTC (permalink / raw)
To: linux-sh
Hi Morimoto-san,
Thanks for your patch.
On Fri, Feb 7, 2014 at 5:34 PM, Kuninori Morimoto
<kuninori.morimoto.gx@gmail.com> wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> arch/arm/boot/dts/r8a7790-lager.dts | 84 +++++++++++++++++++++++++++++++++++
> 1 file changed, 84 insertions(+)
>
> diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
> index 1081c5e..972c75a 100644
> --- a/arch/arm/boot/dts/r8a7790-lager.dts
> +++ b/arch/arm/boot/dts/r8a7790-lager.dts
> @@ -56,6 +56,54 @@
> regulator-boot-on;
> regulator-always-on;
> };
> +
> + vcc_sdhi0: regulator@1 {
> + compatible = "regulator-fixed";
> +
> + regulator-name = "SDHI0 Vcc";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> +
> + gpio = <&gpio5 24 GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> + };
> +
> + vccq_sdhi0: regulator@2 {
> + compatible = "regulator-gpio";
> +
> + regulator-name = "SDHI0 VccQ";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <3300000>;
> +
> + gpios = <&gpio5 29 GPIO_ACTIVE_HIGH>;
> + gpios-states = <1>;
> + states = <3300000 1
> + 1800000 0>;
> + };
> +
> + vcc_sdhi2: regulator@3 {
> + compatible = "regulator-fixed";
> +
> + regulator-name = "SDHI0 Vcc";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> +
> + gpio = <&gpio5 25 GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> + };
> +
> + vccq_sdhi2: regulator@4 {
> + compatible = "regulator-gpio";
> +
> + regulator-name = "SDHI0 VccQ";
After some testing I can see that "regulator-name" contains a typo
above. Please use SDHI2 as name for SDHI2 devices, not SDHI0. =)
Can you make a V2?
Thanks,
/ magnus
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] ARM: shmobile: lager: add SDHI0/2 support on DTS
2014-02-07 8:34 [PATCH 2/2] ARM: shmobile: lager: add SDHI0/2 support on DTS Kuninori Morimoto
2014-02-12 5:53 ` Magnus Damm
@ 2014-02-12 6:13 ` Kuninori Morimoto
1 sibling, 0 replies; 3+ messages in thread
From: Kuninori Morimoto @ 2014-02-12 6:13 UTC (permalink / raw)
To: linux-sh
Hi Magnus
> > + vcc_sdhi2: regulator@3 {
> > + compatible = "regulator-fixed";
> > +
> > + regulator-name = "SDHI0 Vcc";
> > + regulator-min-microvolt = <3300000>;
> > + regulator-max-microvolt = <3300000>;
> > +
> > + gpio = <&gpio5 25 GPIO_ACTIVE_HIGH>;
> > + enable-active-high;
> > + };
> > +
> > + vccq_sdhi2: regulator@4 {
> > + compatible = "regulator-gpio";
> > +
> > + regulator-name = "SDHI0 VccQ";
>
> After some testing I can see that "regulator-name" contains a typo
> above. Please use SDHI2 as name for SDHI2 devices, not SDHI0. =)
Grr...
Thank you for pointing it
I will send v2 patch
Best regards
---
Kuninori Morimoto
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-02-12 6:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-07 8:34 [PATCH 2/2] ARM: shmobile: lager: add SDHI0/2 support on DTS Kuninori Morimoto
2014-02-12 5:53 ` Magnus Damm
2014-02-12 6:13 ` Kuninori Morimoto
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).