From: Yoshinori Sato <ysato@users.sourceforge.jp>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: dalias@libc.org, geert@linux-m68k.org, luto@kernel.org,
clang-built-linux@googlegroups.com,
Masahiro Yamada <yamada.masahiro@socionext.com>,
linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] sh: vsyscall: drop unnecessary cc-ldoption
Date: Sun, 12 May 2019 04:29:56 +0000 [thread overview]
Message-ID: <87tve0qoqj.wl-ysato@users.sourceforge.jp> (raw)
In-Reply-To: <20190424180223.253025-1-ndesaulniers@google.com>
On Thu, 25 Apr 2019 03:02:21 +0900,
Nick Desaulniers wrote:
>
> Towards the goal of removing cc-ldoption, it seems that --hash-style> was added to binutils 2.17.50.0.2 in 2006. The minimal required version
> of binutils for the kernel according to
> Documentation/process/changes.rst is 2.20.
>
> Link: https://gcc.gnu.org/ml/gcc/2007-01/msg01141.html
> Cc: clang-built-linux@googlegroups.com
> Suggested-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Acked-by: Yoshinori Sato <ysato@users.sourceforge.jp>
> ---
> Changes V1 -> V2:
> * update commit subject and message as per Masahiro/Geert.
>
> To Geert's question about minimum binutils versions; no change needed to
> binutils.
>
>
> arch/sh/kernel/vsyscall/Makefile | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/sh/kernel/vsyscall/Makefile b/arch/sh/kernel/vsyscall/Makefile
> index 5db6579bc44c..6e8664448048 100644
> --- a/arch/sh/kernel/vsyscall/Makefile
> +++ b/arch/sh/kernel/vsyscall/Makefile
> @@ -15,8 +15,7 @@ quiet_cmd_syscall = SYSCALL $@
>
> export CPPFLAGS_vsyscall.lds += -P -C -Ush
>
> -vsyscall-flags = -shared -s -Wl,-soname=linux-gate.so.1 \
> - $(call cc-ldoption, -Wl$(comma)--hash-style=sysv)
> +vsyscall-flags = -shared -s -Wl,-soname=linux-gate.so.1 -Wl,--hash-style=sysv
>
> SYSCFLAGS_vsyscall-trapa.so = $(vsyscall-flags)
>
> --
> 2.21.0.593.g511ec345e18-goog
>
--
Yosinori Sato
prev parent reply other threads:[~2019-05-12 4:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-23 20:29 [PATCH] sh: require --Wl,--hash-style=sysv Nick Desaulniers
2019-04-24 6:27 ` Geert Uytterhoeven
2019-04-24 6:37 ` Masahiro Yamada
2019-04-24 6:39 ` Masahiro Yamada
2019-04-24 18:02 ` [PATCH v2] sh: vsyscall: drop unnecessary cc-ldoption Nick Desaulniers
2019-04-30 20:26 ` Nick Desaulniers
2019-05-08 19:22 ` Nick Desaulniers
2019-05-09 0:44 ` Masahiro Yamada
2019-05-09 6:09 ` John Paul Adrian Glaubitz
2019-05-09 7:07 ` Masahiro Yamada
2019-05-09 8:44 ` John Paul Adrian Glaubitz
2019-05-12 4:31 ` Yoshinori Sato
2019-05-12 4:29 ` Yoshinori Sato [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tve0qoqj.wl-ysato@users.sourceforge.jp \
--to=ysato@users.sourceforge.jp \
--cc=clang-built-linux@googlegroups.com \
--cc=dalias@libc.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=luto@kernel.org \
--cc=ndesaulniers@google.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).