From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kuninori Morimoto Date: Thu, 28 Aug 2014 10:36:39 +0000 Subject: Re: [PATCH v4] mmc: tmio: ensure that the clock has been stopped before set_clock Message-Id: <87vbpchpe1.wl%kuninori.morimoto.gx@gmail.com> List-Id: References: <87simtenpi.wl%kuninori.morimoto.gx@renesas.com> <87pphxe2q0.wl%kuninori.morimoto.gx@renesas.com> <53AD638C.5060907@renesas.com> <87egxehsec.wl%kuninori.morimoto.gx@gmail.com> <87bnr9tgwj.wl%kuninori.morimoto.gx@gmail.com> <87bnr5ic6h.wl%kuninori.morimoto.gx@gmail.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Ulf Hansson Cc: Simon , Chris Ball , Ian Molton , Morimoto , Magnus , Linux-SH , linux-mmc Hi Ulf > > I don't think this is needed. Let me elaborate on why. > > > > There two scenarios for when you may come down this path. > > > > Either after ->probe() or after a MMC_POWER_OFF has been handled. In > > both scenarios, tmio_mmc_clk_stop(host) has already been invoked. > > > > Well, actually in the ->probe() we invoke tmio_mmc_clk_stop() and then > > tmio_mmc_reset(), should those maybe be done in reverse order to make > > sure the clock is stopped? (snip) > > To get runtime PM resumed, you must first be runtime PM suspended. In > > the runtime PM suspend callback we have already invoked > > tmio_mmc_set_clock(). I see Thank you for you detail explain about that Best regards --- Kuninori Morimoto