From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>
Date: Wed, 08 Jan 2014 09:11:37 +0000
Subject: Re: [PATCH] ARM: shmobile: r8a7790: add audio clocks
Message-Id: <87wqiax2gq.wl%kuninori.morimoto.gx@gmail.com>
List-Id: <linux-sh.vger.kernel.org>
References: <8738l1jzfv.wl%kuninori.morimoto.gx@gmail.com>
In-Reply-To: <8738l1jzfv.wl%kuninori.morimoto.gx@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: linux-sh@vger.kernel.org


Hi Laurent

> > >  - add non-DT "audio_clk_xx" support without common clock settings today
> > >  - merge window
> > >  - fixup driver/platform/clock as above style
> > >  - add common clock setting for DT
> > >  - add sound DT support
> > 
> > I can send sound driver support patch
> > if "audio_clk_xx" patch was accepted.
> > But it is for non-DT version
> 
> I think you can start by fixing the driver for the non-DT case, DT support can 
> come at a later time.
> 
> You can first add the following clk_lookup entries to arch/arm/mach-
> shmobile/clock-r8a7790.c
> 
>         CLKDEV_ICK_ID("rcar_sound", "clk_a",    &audio_clk_a),
>         CLKDEV_ICK_ID("rcar_sound", "clk_b",    &audio_clk_b),
>         CLKDEV_ICK_ID("rcar_sound", "clk_c",    &audio_clk_c),
> 
> and then fix the adg driver with
> 
>         adg->clk[CLKA] = clk_get(&pdev->dev, "clk_a");
>         adg->clk[CLKB] = clk_get(&pdev->dev, "clk_b");
>         adg->clk[CLKC] = clk_get(&pdev->dev, "clk_c");
>         adg->clk[CLKI] = clk_get(&pdev->dev, "internal");

Hmm...
sorry, but I can't agree.
ASoC branch is based on ALSA branch,
and it doesn't include Simon's branch yet.
OTOH, BockW already has sound support on Simon branch,
and it has audio_clk_b settings.

If I used your idea...

 1) add "rcar_sound" base "clk_x" on Simon branch
    but, sound driver can't care about it in this timing.
    => Sound doesn't work on Lager, I can't send sound support patch.
    => Sound will be supported next-next merge timing

 2) fixup adg driver needs Simon branch merge.
    because it should care BockW in same timing.
    => This fixup will happen after next merge timing

If you can accept "current style" audio_clk_x...

 1) I can send sound support patch immediately for Lager
 2) adg driver fixup happen after next merge,
    then, BockW/Lager are cared in same patch.

There is confusable branch merge timing issue here...
Your idea is nice, but it needs very long time.
This means Lager sound support will be late.

Best regards
---
Kuninori Morimoto