From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kuninori Morimoto Date: Tue, 09 Sep 2014 00:09:02 +0000 Subject: Re: [PATCH 2/7 v3] mmc: use .multi_io_quirk on omap_hsmmc Message-Id: <87zje97izx.wl%kuninori.morimoto.gx@gmail.com> List-Id: References: <87r3zvzohj.wl%kuninori.morimoto.gx@gmail.com> <87bnqx78xr.wl%kuninori.morimoto.gx@gmail.com> <878um178vn.wl%kuninori.morimoto.gx@gmail.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Ulf Hansson Cc: Chris Ball , Simon , Kuninori Morimoto , Linux-SH , linux-mmc Hi Ulf > > diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c > > index ece1634..7b41f57 100644 > > --- a/drivers/mmc/host/omap_hsmmc.c > > +++ b/drivers/mmc/host/omap_hsmmc.c > > @@ -219,6 +219,7 @@ struct omap_hsmmc_host { > > #define AUTO_CMD23 (1 << 0) /* Auto CMD23 support */ > > #define HSMMC_SDIO_IRQ_ENABLED (1 << 1) /* SDIO irq enabled */ > > #define HSMMC_WAKE_IRQ_ENABLED (1 << 2) > > +#define HSMMC_NO_MULTI_READ (1 << 3) > > struct omap_hsmmc_next next_data; > > struct omap_mmc_platform_data *pdata; > > }; (snip) > > #ifdef CONFIG_DEBUG_FS > > @@ -2101,7 +2116,7 @@ static int omap_hsmmc_probe(struct platform_device *pdev) > > > > if (host->pdata->controller_flags & OMAP_HSMMC_BROKEN_MULTIBLOCK_READ) { > > dev_info(&pdev->dev, "multiblock reads disabled due to 35xx erratum 2.1.1.128; MMC read performance may suffer\n"); > > - mmc->caps2 |= MMC_CAP2_NO_MULTI_READ; > > An option to adding yet another flag, would be to assign > ->multi_io_quirk = omap_hsmmc_multi_io_quirk() here? Isn't that > actually better for those variants that doesn't suffer from this HW > bug? This means we need to copy this ops for each driver ? Otherwise, it breaks behavior if many drivers were probed. Best regards --- Kuninori Morimoto